From de6ecd0101606cd2dcf9a970e8bd7784fb4962d9 Mon Sep 17 00:00:00 2001 From: Robert Zieba Date: Tue, 20 Sep 2022 12:36:12 -0600 Subject: util/spd_tools: Change Mendocino to use 0x13 for LP5x memory type Mendocino supports LP5x but currently doesn't support SPDs that use the LP5x memory type, 0x15. This commit updates set 1 SPDs, which are currently only used for mendocino, to use 0x13 for their memory type. BUG=b:245509394 TEST=Generated SPDs, verified that only set 1 have changed to 0x13 Change-Id: I46606cb5ff871296d0214e1f781c3b22e93d24ea Signed-off-by: Robert Zieba Reviewed-on: https://review.coreboot.org/c/coreboot/+/67747 Reviewed-by: Karthik Ramasubramanian Reviewed-by: Matt DeVillier Tested-by: build bot (Jenkins) Reviewed-by: Paul Menzel --- util/spd_tools/src/spd_gen/lp5.go | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) (limited to 'util/spd_tools') diff --git a/util/spd_tools/src/spd_gen/lp5.go b/util/spd_tools/src/spd_gen/lp5.go index bf7b8331e1..5d73cd5450 100644 --- a/util/spd_tools/src/spd_gen/lp5.go +++ b/util/spd_tools/src/spd_gen/lp5.go @@ -466,7 +466,9 @@ func LP5GetBankGroups(memAttribs *LP5MemAttributes) int { func LP5EncodeMemoryType(memAttribs *LP5MemAttributes) byte { var b byte - if memAttribs.LP5X { + // Mendocino supports LP5x, but doesn't support 0x15 as a memory type currently. + // Temporary workaround until it's supported with ABL changes + if memAttribs.LP5X && LP5CurrSet != 1 { b = LP5XSPDValueMemoryType } else { b = LP5SPDValueMemoryType -- cgit v1.2.3