From 0b4f49c792c21a9a806cc57a5563da4947abc0be Mon Sep 17 00:00:00 2001 From: Karthikeyan Ramasubramanian Date: Fri, 29 Jul 2022 17:19:48 -0600 Subject: util/spd_tools/spd_gen/lp5: Remove maxSpeed for Sabrina Firmware component that does memory training already limits the memory controller to train at 5500 Mbps for all memory parts in Sabrina. Hence removing this interim SPD change to limit the speed. BUG=b:238074863 TEST=Build and boot to OS in Skyrim. Signed-off-by: Karthikeyan Ramasubramanian Change-Id: I2bc82c7407a97aac282708c3e0bd56ae99a8fc31 Reviewed-on: https://review.coreboot.org/c/coreboot/+/66290 Reviewed-by: Raul Rangel Tested-by: build bot (Jenkins) --- util/spd_tools/src/spd_gen/lp5.go | 12 ------------ 1 file changed, 12 deletions(-) (limited to 'util/spd_tools') diff --git a/util/spd_tools/src/spd_gen/lp5.go b/util/spd_tools/src/spd_gen/lp5.go index 64fb53fbe2..09387c740b 100644 --- a/util/spd_tools/src/spd_gen/lp5.go +++ b/util/spd_tools/src/spd_gen/lp5.go @@ -70,7 +70,6 @@ type LP5Set struct { otherOptionalFeatures byte busWidthEncoding byte speedToTCKMinPs map[int]int - maxSpeedMbps int } /* ------------------------------------------------------------------------------------------ */ @@ -235,8 +234,6 @@ var LP5SetInfo = map[int]LP5Set{ * Set to 0x02. */ busWidthEncoding: 0x02, - /* Sabrina supports max speed of 5500 MT/s */ - maxSpeedMbps: 5500, }, } @@ -640,14 +637,6 @@ func LP5EncodeTRFCPBMinLsb(memAttribs *LP5MemAttributes) byte { return byte(convNsToMtb(memAttribs.TRFCPBNs) & 0xff) } -func LP5UpdateSpeedMbps(memAttribs *LP5MemAttributes) { - f, ok := LP5SetInfo[LP5CurrSet] - - if ok && f.maxSpeedMbps != 0 && memAttribs.SpeedMbps > f.maxSpeedMbps { - memAttribs.SpeedMbps = f.maxSpeedMbps - } -} - func LP5UpdateTCKMin(memAttribs *LP5MemAttributes) { if memAttribs.TCKMinPs == 0 { memAttribs.TCKMinPs = LP5GetTCKMinPs(memAttribs) @@ -695,7 +684,6 @@ func LP5UpdateTRPPB(memAttribs *LP5MemAttributes) { } func lp5UpdateMemoryAttributes(memAttribs *LP5MemAttributes) { - LP5UpdateSpeedMbps(memAttribs) LP5UpdateTCKMin(memAttribs) LP5UpdateTAAMin(memAttribs) LP5UpdateTRFCAB(memAttribs) -- cgit v1.2.3