From d60cc97526ae14b04d105e94d7ddcd86d3b18f00 Mon Sep 17 00:00:00 2001 From: Julius Werner Date: Mon, 4 Mar 2019 18:22:51 -0800 Subject: lint/kconfig: Fix check for IS_ENABLED(XXX) where someone forgot CONFIG_ This is a great check, but unfortunately it's currently not effective because most uses of IS_ENABLED() do not have whitespace in front of them (they're mostly used as part of an if (IS_ENABLED(...)) condition). This patch makes the linter a little more generous in what it considers in scope to avoid these false negatives in the future. Change-Id: I2296410c73cd6e918465c90db33e782936bec0f9 Signed-off-by: Julius Werner Reviewed-on: https://review.coreboot.org/c/coreboot/+/31746 Reviewed-by: Patrick Georgi Reviewed-by: Nico Huber Tested-by: build bot (Jenkins) --- util/lint/kconfig_lint | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'util/lint') diff --git a/util/lint/kconfig_lint b/util/lint/kconfig_lint index eddd8de6ee..dc01e718a5 100755 --- a/util/lint/kconfig_lint +++ b/util/lint/kconfig_lint @@ -236,11 +236,11 @@ sub check_for_ifdef { my @collected_is_enabled; if ($dont_use_git_grep) { @collected_is_enabled = - `grep -Irn -- "[[:space:]]IS_ENABLED[[:space:]]*(.*)" | grep -v '$exclude_dirs_and_files' | grep -v "kconfig.h"`; + `grep -Irn -- "\\