From 38c731413703bee1a773dccd7253ca186a4c5997 Mon Sep 17 00:00:00 2001 From: Martin Roth Date: Thu, 27 Jan 2022 15:06:03 -0700 Subject: util/lint: Remove SuperIO from checkpatch spellcheck Patch 423e9e0fc0: Documentation/lint: Use Super I/O instead of SuperIO added the word SuperIO to the checkpatch spelling list. There were unfortunately some issues with this. 1) This introduced a problem because the comparison is used in different cases in different places. The misspelled word is compared ignoring the case, but when looking for the correct word, it looks through the list for the misspelling in all lowercase. When it couldn't find the word "superio" in the list, the variable came back uninitialized. 2) The spellcheck feature isn't enabled in checkpatch unless the option --strict is enabled, so this wasn't getting reported anyway. 3) SuperIO (or superio) will match the KCONFIG options such as CONFIG_SUPERIO_NUVOTON_NCT5104D, and suggest "Super I/O" which doesn't make any sense. Signed-off-by: Martin Roth Change-Id: I464305af539926ac8a45c9c0d59eeb2c78dea17a Reviewed-on: https://review.coreboot.org/c/coreboot/+/61434 Tested-by: build bot (Jenkins) Reviewed-by: Paul Menzel Reviewed-by: HAOUAS Elyes --- util/lint/spelling.txt | 1 - 1 file changed, 1 deletion(-) (limited to 'util/lint') diff --git a/util/lint/spelling.txt b/util/lint/spelling.txt index 3ab42b17ba..96a689e380 100644 --- a/util/lint/spelling.txt +++ b/util/lint/spelling.txt @@ -27,7 +27,6 @@ Debiab||Debian FTBS||FTBFS POSIX-complient||POSIX-compliant READEME||README -SuperIO||Super I/O aaccessibility||accessibility aaccession||accession abailable||available -- cgit v1.2.3