From 59c2c8b07966a06fd742bc79efb960b8a900fbbc Mon Sep 17 00:00:00 2001 From: Stefan Reinauer Date: Wed, 6 May 2015 11:10:18 -0700 Subject: checkpatch: fine tune checks Fine tune the following two checks: - Check for incorrect file permissions This one had a linux path hard coded, so it would choke on some commits unnecessarily. - FILE_PATH_CHANGES seems to not be working correctly. It will choke on added / deleted files even if the MAINTAINERS file is touched. Hence, switch from WARN to CHK (as WARN currently blocks commits as well) Change-Id: I9fccfbd75e94f420de45cf8b58071e3198065cf3 Signed-off-by: Stefan Reinauer Reviewed-on: http://review.coreboot.org/10123 Tested-by: build bot (Jenkins) Reviewed-by: Patrick Georgi --- util/lint/checkpatch.pl | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) (limited to 'util/lint/checkpatch.pl') diff --git a/util/lint/checkpatch.pl b/util/lint/checkpatch.pl index 2f1f56cadd..894e5d7685 100755 --- a/util/lint/checkpatch.pl +++ b/util/lint/checkpatch.pl @@ -2069,7 +2069,8 @@ sub process { # Check for incorrect file permissions if ($line =~ /^new (file )?mode.*[7531]\d{0,2}$/) { my $permhere = $here . "FILE: $realfile\n"; - if ($realfile !~ m@scripts/@ && + if ($realfile !~ m@util/lint/@ && + $realfile !~ m@util/scripts/@ && $realfile !~ /\.(py|pl|awk|sh)$/) { ERROR("EXECUTE_PERMISSIONS", "do not set execute permissions for source files\n" . $permhere); @@ -2194,7 +2195,7 @@ sub process { ($line =~ /\{\s*([\w\/\.\-]*)\s*\=\>\s*([\w\/\.\-]*)\s*\}/ && (defined($1) || defined($2))))) { $reported_maintainer_file = 1; - WARN("FILE_PATH_CHANGES", + CHK("FILE_PATH_CHANGES", "added, moved or deleted file(s), does MAINTAINERS need updating?\n" . $herecurr); } -- cgit v1.2.3