From 1f30b244b296a131f4eaf95962bab048f8b3d481 Mon Sep 17 00:00:00 2001 From: Martin Roth Date: Thu, 18 Jan 2024 18:46:58 -0700 Subject: util: Rename Makefiles from .inc to .mk The .inc suffix is confusing to various tools as it's not specific to Makefiles. This means that editors don't recognize the files, and don't open them with highlighting and any other specific editor functionality. This issue is also seen in the release notes generation script where Makefiles get renamed before running cloc. Signed-off-by: Martin Roth Change-Id: I434940ebb46853980596f7ad55d27a62c90280fa Reviewed-on: https://review.coreboot.org/c/coreboot/+/80123 Tested-by: build bot (Jenkins) Reviewed-by: Felix Singer Reviewed-by: Felix Held --- util/ifdtool/Makefile | 2 +- util/ifdtool/Makefile.inc | 19 ------------------- util/ifdtool/Makefile.mk | 19 +++++++++++++++++++ 3 files changed, 20 insertions(+), 20 deletions(-) delete mode 100644 util/ifdtool/Makefile.inc create mode 100644 util/ifdtool/Makefile.mk (limited to 'util/ifdtool') diff --git a/util/ifdtool/Makefile b/util/ifdtool/Makefile index c0210693d8..72a4dabe5c 100644 --- a/util/ifdtool/Makefile +++ b/util/ifdtool/Makefile @@ -10,7 +10,7 @@ HOSTCC ?= $(CC) HOSTCFLAGS ?= $(CFLAGS) top := ../.. objutil := .. -include Makefile.inc +include Makefile.mk PROGRAM=$(objutil)/ifdtool/ifdtool diff --git a/util/ifdtool/Makefile.inc b/util/ifdtool/Makefile.inc deleted file mode 100644 index 2b97bf51c8..0000000000 --- a/util/ifdtool/Makefile.inc +++ /dev/null @@ -1,19 +0,0 @@ -# SPDX-License-Identifier: BSD-3-Clause - -ifdtoolobj = ifdtool.o fmap.o kv_pair.o valstr.o - -IFDTOOLCFLAGS = -O2 -g -Wall -Wextra -Wmissing-prototypes -Werror -IFDTOOLCFLAGS += -I$(top)/src/commonlib/include -I$(top)/src/commonlib/bsd/include -IFDTOOLCFLAGS += -I$(top)/util/cbfstool/flashmap -IFDTOOLCFLAGS += -include $(top)/src/commonlib/bsd/include/commonlib/bsd/compiler.h -IFDTOOLCFLAGS += -D_DEFAULT_SOURCE # for endianness converting functions - -$(objutil)/ifdtool/%.o: $(top)/util/ifdtool/%.c - $(HOSTCC) $(IFDTOOLCFLAGS) $(HOSTCFLAGS) -c -o $@ $< - -$(objutil)/ifdtool/%.o: $(top)/util/cbfstool/flashmap/%.c - $(HOSTCC) $(IFDTOOLCFLAGS) $(HOSTCFLAGS) -c -o $@ $< - -$(objutil)/ifdtool/ifdtool: $(addprefix $(objutil)/ifdtool/,$(ifdtoolobj)) - printf " IFDTOOL\n" - $(HOSTCC) ${LDFLAGS} $(addprefix $(objutil)/ifdtool/,$(ifdtoolobj)) -o $@ diff --git a/util/ifdtool/Makefile.mk b/util/ifdtool/Makefile.mk new file mode 100644 index 0000000000..2b97bf51c8 --- /dev/null +++ b/util/ifdtool/Makefile.mk @@ -0,0 +1,19 @@ +# SPDX-License-Identifier: BSD-3-Clause + +ifdtoolobj = ifdtool.o fmap.o kv_pair.o valstr.o + +IFDTOOLCFLAGS = -O2 -g -Wall -Wextra -Wmissing-prototypes -Werror +IFDTOOLCFLAGS += -I$(top)/src/commonlib/include -I$(top)/src/commonlib/bsd/include +IFDTOOLCFLAGS += -I$(top)/util/cbfstool/flashmap +IFDTOOLCFLAGS += -include $(top)/src/commonlib/bsd/include/commonlib/bsd/compiler.h +IFDTOOLCFLAGS += -D_DEFAULT_SOURCE # for endianness converting functions + +$(objutil)/ifdtool/%.o: $(top)/util/ifdtool/%.c + $(HOSTCC) $(IFDTOOLCFLAGS) $(HOSTCFLAGS) -c -o $@ $< + +$(objutil)/ifdtool/%.o: $(top)/util/cbfstool/flashmap/%.c + $(HOSTCC) $(IFDTOOLCFLAGS) $(HOSTCFLAGS) -c -o $@ $< + +$(objutil)/ifdtool/ifdtool: $(addprefix $(objutil)/ifdtool/,$(ifdtoolobj)) + printf " IFDTOOL\n" + $(HOSTCC) ${LDFLAGS} $(addprefix $(objutil)/ifdtool/,$(ifdtoolobj)) -o $@ -- cgit v1.2.3