From 26058dca96d928ececf488286112cb1590f7b61e Mon Sep 17 00:00:00 2001 From: Subrata Banik Date: Wed, 26 Aug 2020 15:12:16 +0530 Subject: util/ifdtool: Identify between ICH and PCH Revision Consider IBEX_PEAK onwards all chipsets are belong to PCH family. BUG=b:153888802 TEST=Able to print correct PCH revision on Hatch Platform. > ifdtool -d coreboot.rom Without this CL : ICH Revision: 300 series Cannon Point/ 400 series Ice Point With this CL : PCH Revision: 300 series Cannon Point/ 400 series Ice Point Signed-off-by: Subrata Banik Change-Id: Ifd40dddc9179f347c0ea75149ec08089a829fdb4 Reviewed-on: https://review.coreboot.org/c/coreboot/+/44816 Tested-by: build bot (Jenkins) Reviewed-by: Tim Wawrzynczak --- util/ifdtool/ifdtool.c | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) (limited to 'util/ifdtool/ifdtool.c') diff --git a/util/ifdtool/ifdtool.c b/util/ifdtool/ifdtool.c index 2388ebca7e..fa7817a3bc 100644 --- a/util/ifdtool/ifdtool.c +++ b/util/ifdtool/ifdtool.c @@ -513,6 +513,13 @@ static void decode_component_density(unsigned int density) } } +static int is_platform_with_pch(void) +{ + if (chipset >= CHIPSET_5_SERIES_IBEX_PEAK) + return 1; + + return 0; +} static void dump_fcba(const fcba_t *fcba) { printf("\nFound Component Section\n"); @@ -759,7 +766,8 @@ static void dump_fd(char *image, int size) if (!fdb) exit(EXIT_FAILURE); - printf("ICH Revision: %s\n", ich_chipset_names[chipset]); + printf("%s", is_platform_with_pch() ? "PCH" : "ICH"); + printf(" Revision: %s\n", ich_chipset_names[chipset]); printf("FLMAP0: 0x%08x\n", fdb->flmap0); printf(" NR: %d\n", (fdb->flmap0 >> 24) & 7); printf(" FRBA: 0x%x\n", ((fdb->flmap0 >> 16) & 0xff) << 4); -- cgit v1.2.3