From d906bb68c3be218046d257c6870c9636e0e198cf Mon Sep 17 00:00:00 2001 From: Julius Werner Date: Tue, 16 May 2017 13:54:18 -0700 Subject: cbmem_console: Improve 'cbmem -1' behavior for truncated pre-CBMEM logs The 'cbmem -1' flag that cuts off console output before the last boot will ignore content from earlier stages if it was truncated due to lack of pre-CBMEM console space. This patch makes the "log truncated" message more specific and adds it as an additional cut-off marker to 'cbmem -1' to counteract that problem. Also raise the log level of the coreboot banner one step to BIOS_NOTICE to make it more likely to be included in the output for 'cbmem -1' to find. (I believe NOTICE is reasonable but I wouldn't want to go as far as WARN which should be reserved for actual problems. Of course this is not ideal, but then again, our whole log-level system really isn't... it would be better if we could make it always print a banner to the CBMEM console without affecting the UART at the same time, but that would require a larger amount of work.) Change-Id: I58288593dfa757e14f4a9da4ffa7e27b0b66feb9 Reported-by: https://ticket.coreboot.org/issues/117 Signed-off-by: Julius Werner Reviewed-on: https://review.coreboot.org/19720 Tested-by: build bot (Jenkins) Reviewed-by: Aaron Durbin --- util/cbmem/cbmem.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) (limited to 'util/cbmem/cbmem.c') diff --git a/util/cbmem/cbmem.c b/util/cbmem/cbmem.c index 48a1bc963d..daa7b566ca 100644 --- a/util/cbmem/cbmem.c +++ b/util/cbmem/cbmem.c @@ -670,9 +670,12 @@ static void dump_console(int one_boot_only) cursor = 0; if (one_boot_only) { #define BANNER_REGEX(stage) "\n\ncoreboot-[^\n]* " stage " starting\\.\\.\\.\n" +#define OVERFLOW_REGEX(stage) "\n*** Pre-CBMEM " stage " console overflowed" const char *regex[] = { BANNER_REGEX("bootblock"), BANNER_REGEX("romstage"), - BANNER_REGEX("ramstage")}; + OVERFLOW_REGEX("romstage"), + BANNER_REGEX("ramstage"), + OVERFLOW_REGEX("ramstage") }; int i; for (i = 0; !cursor && i < ARRAY_SIZE(regex); i++) { -- cgit v1.2.3