From f9b8ed86dde6b9d5bb3f56259a7351ec6304f8ea Mon Sep 17 00:00:00 2001 From: Kyösti Mälkki Date: Sat, 27 Dec 2014 13:08:54 +0200 Subject: cbfstool: Fix update-fit command MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Regression in commit 3fcde22 caused parse_microcode_blob() to access data outside cpu_microcode_blob.bin file in CBFS and create invalid Intel Firmware Interface Table entries. Change-Id: I1a687060084c2acd6cac5f5053b74a332b4ac714 Signed-off-by: Kyösti Mälkki Reviewed-on: http://review.coreboot.org/7958 Tested-by: build bot (Jenkins) Reviewed-by: Alexandru Gagniuc Reviewed-by: Paul Menzel --- util/cbfstool/fit.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'util/cbfstool') diff --git a/util/cbfstool/fit.c b/util/cbfstool/fit.c index bf6c6d4dd5..0652129311 100644 --- a/util/cbfstool/fit.c +++ b/util/cbfstool/fit.c @@ -207,8 +207,8 @@ static int parse_microcode_blob(struct cbfs_image *image, uint32_t current_offset; uint32_t file_length; - current_offset = (int)((char *)mcode_file - image->buffer.data); fit_header(mcode_file, ¤t_offset, &file_length); + current_offset += (int)((char *)mcode_file - image->buffer.data); num_mcus = 0; while (file_length > sizeof(struct microcode_header)) -- cgit v1.2.3