From aa2f739ae87386b8a29068ecfdc2b25bcf4a19ca Mon Sep 17 00:00:00 2001 From: "Ronald G. Minnich" Date: Tue, 3 Dec 2013 11:13:35 -0800 Subject: cbfs: fix issues with word size and endianness. Add XDR functions and use them to convert the ELF headers to native headers, using the Elf64 structs to ensure we accomodate all word sizes. Also, use these XDR functions for output. This may seem overly complex but it turned out to be much the easiest way to do this. Note that the basic elf parsing function in cbfs-mkstage.c now works over all ELF files, for all architectures, endian, and word size combinations. At the same time, the basic elf parsing in cbfs-mkstage.c is a loop that has no architecture-specific conditionals. Add -g to the LDFLAGS while we're here. It's on the CFLAGS so there is no harm done. This code has been tested on all chromebooks that use coreboot to date. I added most of the extra checks from ChromeOS and they triggered a lot of warnings, hence the other changes. I had to take -Wshadow back out due to the many errors it triggers in LZMA. BUG=None TEST=Build and boot for Peppy; works fine. Build and boot for nyan, works fine. Build for qemu targets and armv8 targets. BRANCH=None Change-Id: I5a4cee9854799189115ac701e22efc406a8d902f Signed-off-by: Ronald G. Minnich Reviewed-on: https://chromium-review.googlesource.com/178606 Reviewed-by: Ronald Minnich Commit-Queue: Ronald Minnich Tested-by: Ronald Minnich Reviewed-on: http://review.coreboot.org/4817 Reviewed-by: Alexandru Gagniuc Tested-by: build bot (Jenkins) Reviewed-by: Ronald G. Minnich --- util/cbfstool/compress.c | 2 -- 1 file changed, 2 deletions(-) (limited to 'util/cbfstool/compress.c') diff --git a/util/cbfstool/compress.c b/util/cbfstool/compress.c index 9ea1487ff9..38fa03dbed 100644 --- a/util/cbfstool/compress.c +++ b/util/cbfstool/compress.c @@ -26,8 +26,6 @@ #include #include "common.h" -void do_lzma_compress(char *in, int in_len, char *out, int *out_len); - static void lzma_compress(char *in, int in_len, char *out, int *out_len) { do_lzma_compress(in, in_len, out, out_len); -- cgit v1.2.3