From 6310ccc59c1fd87ec5f68c1b0681e70500261e08 Mon Sep 17 00:00:00 2001 From: Sol Boucher Date: Thu, 7 May 2015 21:12:28 -0700 Subject: cbfstool: Don't typedef the comp_algo enum Our style discourages unnecessary typedefs, and this one doesn't gain us anything, nor is it consistent with the surrounding code: there's a function pointer typedef'd nearby, but non-opaque structs aren't. BUG=chromium:482652 TEST=None BRANCH=None Change-Id: Ie7565240639e5b1aeebb08ea005099aaa3557a27 Signed-off-by: Sol Boucher Original-Change-Id: I4285e6b56f99b85b9684f2b98b35e9b35a6c4cb7 Original-Signed-off-by: Sol Boucher Reviewed-on: http://review.coreboot.org/10146 Tested-by: build bot (Jenkins) Reviewed-by: Patrick Georgi --- util/cbfstool/cbfs-mkpayload.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) (limited to 'util/cbfstool/cbfs-mkpayload.c') diff --git a/util/cbfstool/cbfs-mkpayload.c b/util/cbfstool/cbfs-mkpayload.c index 6eebbef9d0..5bebf51440 100644 --- a/util/cbfstool/cbfs-mkpayload.c +++ b/util/cbfstool/cbfs-mkpayload.c @@ -68,7 +68,7 @@ void xdr_get_seg(struct cbfs_payload_segment *out, } int parse_elf_to_payload(const struct buffer *input, struct buffer *output, - comp_algo algo) + enum comp_algo algo) { Elf64_Phdr *phdr; Elf64_Ehdr ehdr; @@ -249,7 +249,7 @@ int parse_flat_binary_to_payload(const struct buffer *input, struct buffer *output, uint32_t loadaddress, uint32_t entrypoint, - comp_algo algo) + enum comp_algo algo) { comp_func_ptr compress; struct cbfs_payload_segment segs[2]; @@ -293,8 +293,8 @@ int parse_flat_binary_to_payload(const struct buffer *input, return 0; } -int parse_fv_to_payload(const struct buffer *input, - struct buffer *output, comp_algo algo) +int parse_fv_to_payload(const struct buffer *input, struct buffer *output, + enum comp_algo algo) { comp_func_ptr compress; struct cbfs_payload_segment segs[2]; -- cgit v1.2.3