From 8c47b1f833cf83c635bdb04f3c6c363bdc3e6669 Mon Sep 17 00:00:00 2001 From: Patrick Georgi Date: Thu, 15 Dec 2016 15:03:55 +0100 Subject: util/broadcom: Add two more NULL checks Change-Id: I088730fd87dd39fa2c36a06c5770fad05a5808b0 Signed-off-by: Patrick Georgi Found-by: Coverity Scan #1323511, #1323512 Reviewed-on: https://review.coreboot.org/17882 Tested-by: build bot (Jenkins) Reviewed-by: Martin Roth --- util/broadcom/secimage/sbi.c | 10 ++++++++++ 1 file changed, 10 insertions(+) (limited to 'util/broadcom') diff --git a/util/broadcom/secimage/sbi.c b/util/broadcom/secimage/sbi.c index d972ba4b07..f156ed5946 100644 --- a/util/broadcom/secimage/sbi.c +++ b/util/broadcom/secimage/sbi.c @@ -109,6 +109,16 @@ int CreateSecureBootImage(int ac, char **av) --ac, ++av; } + if (!bl) { + puts("-bl not set"); + return -1; + } + + if (!privkey) { + puts("-hmac not set"); + return -1; + } + if (stat(bl, &file_stat) == -1) { puts("Can't stat bl"); return -1; -- cgit v1.2.3