From 05ae8f2ff31ba1d02aba15c99025df91588712e1 Mon Sep 17 00:00:00 2001 From: Angel Pons Date: Mon, 8 Mar 2021 10:35:49 +0100 Subject: mainboard: Drop invalid `VGA_BIOS_FILE` defaults MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit If the VGA BIOS file path for `VGA_BIOS_FILE` in a mainboard's Kconfig does not exist in the coreboot tree (including submodules), drop it. These files should be stored in the `site-local` subdirectory and the paths specified for each board in `site-local/Kconfig`. For example: config VGA_BIOS_FILE default "site-local/x200_vbios.bin" if BOARD_LENOVO_X200 Note that this is just an example. There are better ways to structure one's `site-local` subfolder. Using the `CONFIG_MAINBOARD_DIR` option would be one of them, though variants may still need special handling. Also, update autoport to not generate `VGA_BIOS_FILE` defaults. Change-Id: I1b5dfba035a42d7943f270f95fb7d32b285584d2 Signed-off-by: Angel Pons Reviewed-on: https://review.coreboot.org/c/coreboot/+/51340 Tested-by: build bot (Jenkins) Reviewed-by: Nico Huber Reviewed-by: Michael Niewöhner Reviewed-by: Felix Singer --- util/autoport/main.go | 3 --- 1 file changed, 3 deletions(-) (limited to 'util/autoport/main.go') diff --git a/util/autoport/main.go b/util/autoport/main.go index b889a95681..9b0b43666a 100644 --- a/util/autoport/main.go +++ b/util/autoport/main.go @@ -510,9 +510,6 @@ func (g GenericVGA) Scan(ctx Context, addr PCIDevData) { KconfigString["VGA_BIOS_ID"] = fmt.Sprintf("%04x,%04x", addr.PCIVenID, addr.PCIDevID) - KconfigString["VGA_BIOS_FILE"] = fmt.Sprintf("pci%04x,%04x.rom", - addr.PCIVenID, - addr.PCIDevID) PutPCIDevParent(addr, g.Comment, g.MissingParent) IGDEnabled = true } -- cgit v1.2.3