From 794934cbeebb586847c98cc3d7ea04fa09a7330b Mon Sep 17 00:00:00 2001 From: George Burgess IV Date: Wed, 10 Jul 2024 09:41:03 -0600 Subject: amdfwtool: make fields unsigned The value stored in `gen` is only ever `1` or `0`. Storing `1` causes Clang to warn, since the only valid values for a 1-bit int are -1 and 0: ``` amdfwtool.c:1487:27: error: implicit truncation from 'int' to a one-bit wide bit-field changes value from 1 to -1 [-Werror,-Wsingle-bit-bitfield-constant-conversion] 1487 | amd_romsig->efs_gen.gen = EFS_BEFORE_SECOND_GEN; ``` TEST=Rebuilt coreboot; no warning was emitted. Change-Id: Ibd83be8302e8a717db7e7dc86a403b5648976586 Signed-off-by: George Burgess IV Reviewed-on: https://review.coreboot.org/c/coreboot/+/83412 Reviewed-by: Felix Held Reviewed-by: Matt DeVillier Tested-by: build bot (Jenkins) Reviewed-by: Raul Rangel --- util/amdfwtool/amdfwtool.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'util/amdfwtool') diff --git a/util/amdfwtool/amdfwtool.h b/util/amdfwtool/amdfwtool.h index 1dc445c3ab..b2fd2c0006 100644 --- a/util/amdfwtool/amdfwtool.h +++ b/util/amdfwtool/amdfwtool.h @@ -143,8 +143,8 @@ typedef enum _amd_addr_mode { } amd_addr_mode; struct second_gen_efs { /* todo: expand for Server products */ - int gen:1; /* Client products only use bit 0 */ - int reserved:31; + uint32_t gen:1; /* Client products only use bit 0 */ + uint32_t reserved:31; } __attribute__((packed)); #define EFS_SECOND_GEN 0 -- cgit v1.2.3