From feb5d10061927639cc691207d4c0f408f5578123 Mon Sep 17 00:00:00 2001 From: Daniel Kang <daniel.h.kang@intel.com> Date: Wed, 1 Jul 2020 16:49:34 -0700 Subject: mb/google/volteer: Fix world-facing camera LED is always on issue Volteer world-facing camera has a privacy LED and it is supposed to be turned on only when the camera is being used. But the LED is always on and this is to fix the issue. RCAM_SNR_PWR_EN (RearCAMera_SeNsoR_PoWeR_ENable) GPIO, which controls the world-facing camera LED, was not in the power-up and power-down sequence definitions and this caused the issue. BUG=b:160341981 BRANCH=none TEST=Build and boot volteer proto 2 board. Start a camera app and check the world-facing camera LED is only turned on only when the camera is working. Signed-off-by: Daniel Kang <daniel.h.kang@intel.com> Change-Id: I564690baffddfdd0f998525992643aaf16ba4b02 Reviewed-on: https://review.coreboot.org/c/coreboot/+/42985 Reviewed-by: Wonkyu Kim <wonkyu.kim@intel.com> Reviewed-by: Tim Wawrzynczak <twawrzynczak@chromium.org> Reviewed-by: Paul Menzel <paulepanter@users.sourceforge.net> Reviewed-by: Angel Pons <th3fanbus@gmail.com> Reviewed-by: Daniel H Kang <daniel.h.kang@intel.corp-partner.google.com> Tested-by: build bot (Jenkins) <no-reply@coreboot.org> --- .../variants/baseboard/include/baseboard/acpi/mipi_camera.asl | 6 ++++++ 1 file changed, 6 insertions(+) (limited to 'src') diff --git a/src/mainboard/google/volteer/variants/baseboard/include/baseboard/acpi/mipi_camera.asl b/src/mainboard/google/volteer/variants/baseboard/include/baseboard/acpi/mipi_camera.asl index a57566262e..9f7b3e02af 100644 --- a/src/mainboard/google/volteer/variants/baseboard/include/baseboard/acpi/mipi_camera.asl +++ b/src/mainboard/google/volteer/variants/baseboard/include/baseboard/acpi/mipi_camera.asl @@ -163,6 +163,9 @@ Scope (\_SB.PCI0.I2C3) CTXS(GPP_D4) #endif + /* Pull SNRPWR_EN high */ + STXS(GPP_H14) + /* Pull PWREN high */ STXS(GPP_H20) Sleep(2) /* reset pulse width */ @@ -196,6 +199,9 @@ Scope (\_SB.PCI0.I2C3) /* Pull PWREN low */ CTXS(GPP_H20) + /* Pull SNRPWR_EN low */ + CTXS(GPP_H14) + Store(0,STA) } } -- cgit v1.2.3