From f7dbf4afd61fd54b4231685c1f3c1f39b20d996f Mon Sep 17 00:00:00 2001 From: Felix Held Date: Mon, 7 Jun 2021 16:56:04 +0200 Subject: acpi: drop weak implementation of acpi_soc_get_bert_region acpi_soc_get_bert_region only gets called when a chipset's Kconfig selects the ACPI_BERT option in which case the chipset code needs to implement this function. In the case of acpi_soc_get_bert_region not being implemented, but ACPI_BERT being selected for a chipset this patch changes the behavior from never generating a BERT ACPI table to a build error which is more obvious and easier to catch. Signed-off-by: Felix Held Change-Id: Id479fce823d8534a7790f39125d1a2b3635fc029 Reviewed-on: https://review.coreboot.org/c/coreboot/+/55277 Reviewed-by: Lance Zhao Reviewed-by: Tim Wawrzynczak Reviewed-by: Marshall Dawson Tested-by: build bot (Jenkins) --- src/acpi/acpi.c | 6 ------ src/include/acpi/acpi.h | 2 +- 2 files changed, 1 insertion(+), 7 deletions(-) (limited to 'src') diff --git a/src/acpi/acpi.c b/src/acpi/acpi.c index d7d7d3de24..12fa2133ac 100644 --- a/src/acpi/acpi.c +++ b/src/acpi/acpi.c @@ -1559,12 +1559,6 @@ unsigned long acpi_create_lpi_desc_ncst(acpi_lpi_desc_ncst_t *lpi_desc, uint16_t return lpi_desc->header.length; } -/* BERT helpers */ -__weak enum cb_err acpi_soc_get_bert_region(void **region, size_t *length) -{ - return CB_ERR; -} - unsigned long __weak fw_cfg_acpi_tables(unsigned long start) { return 0; diff --git a/src/include/acpi/acpi.h b/src/include/acpi/acpi.h index b1eb664db2..9b73d5be29 100644 --- a/src/include/acpi/acpi.h +++ b/src/include/acpi/acpi.h @@ -1340,7 +1340,7 @@ unsigned long acpi_create_hest_error_source(acpi_hest_t *hest, void acpi_create_lpit(acpi_lpit_t *lpit); unsigned long acpi_create_lpi_desc_ncst(acpi_lpi_desc_ncst_t *lpi_desc, uint16_t uid); -/* For crashlog. */ +/* chipsets that select ACPI_BERT must implement this function */ enum cb_err acpi_soc_get_bert_region(void **region, size_t *length); /* For ACPI S3 support. */ -- cgit v1.2.3