From f3b0500050050e4f103e42fdcf111af232fa874b Mon Sep 17 00:00:00 2001 From: Kerry Sheh Date: Wed, 12 Oct 2011 12:06:23 +0800 Subject: SB800: Hide unused gpp ports Add configure option SB_GPP_UNHIDE_PORTS for mainboard to hide/unhide the unused sb800 gpp ports. Certain gpp port should be hidden, if no device was detected and hotplug feature is disabled for such port. Hidden unused ports makes lspci -vvv get more accurate information under Linux. Test on avalue/eax-785e mainboard. Change-Id: I1d7df0f2ab6ad69b1b99b8bf046411ae7cdb09c0 Signed-off-by: Kerry Sheh Signed-off-by: Kerry Sheh Reviewed-on: http://review.coreboot.org/207 Tested-by: build bot (Jenkins) Reviewed-by: Patrick Georgi --- src/mainboard/advansus/a785e-i/platform_cfg.h | 6 ++++++ src/mainboard/amd/inagua/platform_cfg.h | 6 ++++++ src/mainboard/amd/persimmon/platform_cfg.h | 6 ++++++ src/mainboard/asrock/e350m1/platform_cfg.h | 6 ++++++ src/southbridge/amd/cimx/sb800/cfg.c | 2 +- 5 files changed, 25 insertions(+), 1 deletion(-) (limited to 'src') diff --git a/src/mainboard/advansus/a785e-i/platform_cfg.h b/src/mainboard/advansus/a785e-i/platform_cfg.h index ee68386189..5fd49d6b6a 100644 --- a/src/mainboard/advansus/a785e-i/platform_cfg.h +++ b/src/mainboard/advansus/a785e-i/platform_cfg.h @@ -211,6 +211,12 @@ */ #define SB_GPP_GEN2 TRUE +/** + * @def SB_GPP_UNHIDE_PORTS + * TRUE - ports visable always, even port empty + * FALSE - ports invisable if port empty + */ +#define SB_GPP_UNHIDE_PORTS FALSE /** * @def GEC_CONFIG diff --git a/src/mainboard/amd/inagua/platform_cfg.h b/src/mainboard/amd/inagua/platform_cfg.h index 4a3f080d67..aa7cb5c05c 100644 --- a/src/mainboard/amd/inagua/platform_cfg.h +++ b/src/mainboard/amd/inagua/platform_cfg.h @@ -213,6 +213,12 @@ */ #define SB_GPP_GEN2 TRUE +/** + * @def SB_GPP_UNHIDE_PORTS + * TRUE - ports visable always, even port empty + * FALSE - ports invisable if port empty + */ +#define SB_GPP_UNHIDE_PORTS FALSE /** * @def GEC_CONFIG diff --git a/src/mainboard/amd/persimmon/platform_cfg.h b/src/mainboard/amd/persimmon/platform_cfg.h index e4fedd9336..66aab8bf4b 100644 --- a/src/mainboard/amd/persimmon/platform_cfg.h +++ b/src/mainboard/amd/persimmon/platform_cfg.h @@ -213,6 +213,12 @@ */ #define SB_GPP_GEN2 TRUE +/** + * @def SB_GPP_UNHIDE_PORTS + * TRUE - ports visable always, even port empty + * FALSE - ports invisable if port empty + */ +#define SB_GPP_UNHIDE_PORTS FALSE /** * @def GEC_CONFIG diff --git a/src/mainboard/asrock/e350m1/platform_cfg.h b/src/mainboard/asrock/e350m1/platform_cfg.h index a0cbd118f9..6aa31d2cdb 100644 --- a/src/mainboard/asrock/e350m1/platform_cfg.h +++ b/src/mainboard/asrock/e350m1/platform_cfg.h @@ -213,6 +213,12 @@ */ #define SB_GPP_GEN2 TRUE +/** + * @def SB_GPP_UNHIDE_PORTS + * TRUE - ports visable always, even port empty + * FALSE - ports invisable if port empty + */ +#define SB_GPP_UNHIDE_PORTS FALSE /** * @def GEC_CONFIG diff --git a/src/southbridge/amd/cimx/sb800/cfg.c b/src/southbridge/amd/cimx/sb800/cfg.c index a34dd14baa..2998fa2ff1 100644 --- a/src/southbridge/amd/cimx/sb800/cfg.c +++ b/src/southbridge/amd/cimx/sb800/cfg.c @@ -108,7 +108,7 @@ void sb800_cimx_config(AMDSBCFG *sb_config) sb_config->PORTCONFIG[1].PortCfg.PortPresent = CIMX_OPTION_ENABLED; sb_config->PORTCONFIG[2].PortCfg.PortPresent = CIMX_OPTION_ENABLED; sb_config->PORTCONFIG[3].PortCfg.PortPresent = CIMX_OPTION_ENABLED; - sb_config->GppUnhidePorts = TRUE; //visable always, even port empty + sb_config->GppUnhidePorts = SB_GPP_UNHIDE_PORTS; sb_config->NbSbGen2 = NB_SB_GEN2; sb_config->GppGen2 = SB_GPP_GEN2; -- cgit v1.2.3