From ed75b279a334e3a2c41ef179d7f4dbb8200445fb Mon Sep 17 00:00:00 2001 From: Duncan Laurie Date: Fri, 15 Jul 2016 04:51:45 -0700 Subject: tpm2_tlcl: Use signed integer for tpm2_marshal_command return value The tpm2_marshal_command() function returns a negative value on error, so we must use a signed type for the return value. This was found by the coverity scan: https://scan.coverity.com/projects/coreboot?tab=overview CID:1357675 CID:1357676 Change-Id: I56d2ce7d52b9b70e43378c13c66b55ac2948f218 Signed-off-by: Duncan Laurie Found-by: Coverity Scan Reviewed-on: https://review.coreboot.org/15717 Tested-by: build bot (Jenkins) Reviewed-by: Paul Menzel Reviewed-by: Vadim Bendebury --- src/lib/tpm2_tlcl.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) (limited to 'src') diff --git a/src/lib/tpm2_tlcl.c b/src/lib/tpm2_tlcl.c index d9f9d37533..4ac112a067 100644 --- a/src/lib/tpm2_tlcl.c +++ b/src/lib/tpm2_tlcl.c @@ -21,7 +21,8 @@ static void *tpm_process_command(TPM_CC command, void *command_body) { - size_t out_size, in_size; + ssize_t out_size; + size_t in_size; /* Command/response buffer. */ static uint8_t cr_buffer[TPM_BUFFER_SIZE]; -- cgit v1.2.3