From e0f058ffa8309bd902802074418b5c6e0075a8aa Mon Sep 17 00:00:00 2001 From: Julius Werner Date: Fri, 15 Jan 2021 17:48:11 -0800 Subject: coreboot_table: Use precision when printing lb_gpio name The lb_gpio coreboot table entries use name fields fixed to 16 bytes. GCC will not allow creating a static initializer for such a field with a string of more than 16 characters... but exactly 16 characters is fine, meaning there's no room for the terminating NUL byte. The payloads (at least depthcharge) can deal with this as well because they're checking the size when looking at that table entry, but our printk("%16s") does not and will happily walk over the end until somewhere else in memory we finally find the next NUL byte. We should probably try to avoid strings of exactly 16 characters in this field anyway, just in case -- but since GCC doesn't warn about them they can easily slip back in. So solve this bug by also adding a precision field to the printk, which will make it stop overrunning the string. Signed-off-by: Julius Werner Change-Id: Ifd7beef00d828f9dc2faa4747eace6ac4ca41899 Reviewed-on: https://review.coreboot.org/c/coreboot/+/49496 Tested-by: build bot (Jenkins) Reviewed-by: Angel Pons Reviewed-by: Furquan Shaikh --- src/lib/coreboot_table.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'src') diff --git a/src/lib/coreboot_table.c b/src/lib/coreboot_table.c index 5f8c69bf2a..29be857e1e 100644 --- a/src/lib/coreboot_table.c +++ b/src/lib/coreboot_table.c @@ -165,7 +165,7 @@ static void lb_gpios(struct lb_header *header) " NAME | PORT | POLARITY | VALUE\n", gpios->count); for (g = &gpios->gpios[0]; g < &gpios->gpios[gpios->count]; g++) { - printk(BIOS_INFO, "%16s | ", g->name); + printk(BIOS_INFO, "%16.16s | ", g->name); if (g->port == -1) printk(BIOS_INFO, " undefined | "); else -- cgit v1.2.3