From d992aa6111fcb7bd023377d90692b74a99cfa732 Mon Sep 17 00:00:00 2001 From: Felix Held Date: Sat, 18 Dec 2021 00:41:23 +0100 Subject: soc/amd/common/lpc/espi_util: simplify espi_get_general_configuration The intermediate ret variable isn't needed. Signed-off-by: Felix Held Change-Id: I4e6747cf468c5ba8da6c1a3b20022851e32ad951 Reviewed-on: https://review.coreboot.org/c/coreboot/+/60205 Tested-by: build bot (Jenkins) Reviewed-by: Raul Rangel Reviewed-by: Marshall Dawson --- src/soc/amd/common/block/lpc/espi_util.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) (limited to 'src') diff --git a/src/soc/amd/common/block/lpc/espi_util.c b/src/soc/amd/common/block/lpc/espi_util.c index 4eb700be19..7261bb962f 100644 --- a/src/soc/amd/common/block/lpc/espi_util.c +++ b/src/soc/amd/common/block/lpc/espi_util.c @@ -639,8 +639,7 @@ static int espi_set_configuration(uint16_t slave_reg_addr, uint32_t config) static int espi_get_general_configuration(uint32_t *config) { - int ret = espi_get_configuration(ESPI_SLAVE_GENERAL_CFG, config); - if (ret == -1) + if (espi_get_configuration(ESPI_SLAVE_GENERAL_CFG, config) == -1) return -1; espi_show_slave_general_configuration(*config); -- cgit v1.2.3