From d3b7e2f94af63a42e25738a67c92eb949f520d3d Mon Sep 17 00:00:00 2001 From: Furquan Shaikh Date: Sat, 2 Jan 2021 00:15:23 -0800 Subject: soc/intel/common/uart: Restrict scope of uart_common_init to uart.c uart_common_init is not used outside of soc/intel/common/block/uart.c. This change restricts the scope to this file and drops the declaration from uart.h Change-Id: I499a53506f9b2e91ecc7334bf9b023d342e802fc Signed-off-by: Furquan Shaikh Reviewed-on: https://review.coreboot.org/c/coreboot/+/49211 Reviewed-by: Karthik Ramasubramanian Reviewed-by: Angel Pons Reviewed-by: Tim Wawrzynczak Tested-by: build bot (Jenkins) --- src/soc/intel/common/block/include/intelblocks/uart.h | 6 ------ src/soc/intel/common/block/uart/uart.c | 2 +- 2 files changed, 1 insertion(+), 7 deletions(-) (limited to 'src') diff --git a/src/soc/intel/common/block/include/intelblocks/uart.h b/src/soc/intel/common/block/include/intelblocks/uart.h index 87fdf68868..fd65f4c85e 100644 --- a/src/soc/intel/common/block/include/intelblocks/uart.h +++ b/src/soc/intel/common/block/include/intelblocks/uart.h @@ -23,12 +23,6 @@ struct uart_gpio_pad_config { * 4. SOC will allow common code to set UART into legacy mode if supported. */ -/* - * Common routine to initialize UART controller PCI config space, take it out of - * reset and configure M/N dividers. - */ -void uart_common_init(const struct device *dev, uintptr_t baseaddr); - /* * Check if UART debug controller is initialized * Returns: diff --git a/src/soc/intel/common/block/uart/uart.c b/src/soc/intel/common/block/uart/uart.c index 75c16d4625..1e205ef07f 100644 --- a/src/soc/intel/common/block/uart/uart.c +++ b/src/soc/intel/common/block/uart/uart.c @@ -58,7 +58,7 @@ static int uart_get_valid_index(void) return UART_CONSOLE_INVALID_INDEX; } -void uart_common_init(const struct device *device, uintptr_t baseaddr) +static void uart_common_init(const struct device *device, uintptr_t baseaddr) { #if defined(__SIMPLE_DEVICE__) pci_devfn_t dev = PCI_BDF(device); -- cgit v1.2.3