From d37bc75632867e547ad4c8b1f333a1b5247c88e5 Mon Sep 17 00:00:00 2001 From: Julius Werner Date: Thu, 15 Jan 2015 17:00:21 -0800 Subject: veyron: move setup_chromeos_gpios() prototype to board.h I always had that TODO comment in there but I had already forgotten what I even meant by it. It's really just a simple cleanup... this function is (currently) veyron-specific and doesn't belong in common code. BRANCH=veyron BUG=None TEST=Booted Jerry. Change-Id: Iccd6130c90e67b8ee905e188857c99deda966f14 Signed-off-by: Patrick Georgi Original-Commit-Id: d188398704575ad2fedc2a715e609521da2332b0 Original-Change-Id: I6ce701a15a6542a615d3d81f70aa71662567d4fa Original-Signed-off-by: Julius Werner Original-Reviewed-on: https://chromium-review.googlesource.com/241190 Reviewed-on: http://review.coreboot.org/9733 Tested-by: build bot (Jenkins) Reviewed-by: Stefan Reinauer --- src/mainboard/google/veyron_brain/board.h | 2 +- src/mainboard/google/veyron_danger/board.h | 2 +- src/mainboard/google/veyron_jerry/board.h | 2 +- src/mainboard/google/veyron_mighty/board.h | 2 +- src/mainboard/google/veyron_pinky/board.h | 2 +- src/mainboard/google/veyron_rialto/board.h | 2 +- src/mainboard/google/veyron_speedy/board.h | 2 +- src/vendorcode/google/chromeos/chromeos.h | 3 --- 8 files changed, 7 insertions(+), 10 deletions(-) (limited to 'src') diff --git a/src/mainboard/google/veyron_brain/board.h b/src/mainboard/google/veyron_brain/board.h index 96159d41e8..6e6a62c834 100644 --- a/src/mainboard/google/veyron_brain/board.h +++ b/src/mainboard/google/veyron_brain/board.h @@ -25,6 +25,6 @@ #define GPIO_RESET GPIO(0, B, 5) -/* TODO: move setup_chromeos_gpios() here once bootblock code is in mainboard */ +void setup_chromeos_gpios(void); #endif /* __MAINBOARD_GOOGLE_VEYRON_BRAIN_BOARD_H */ diff --git a/src/mainboard/google/veyron_danger/board.h b/src/mainboard/google/veyron_danger/board.h index bd826aafdf..4d0e8bec34 100644 --- a/src/mainboard/google/veyron_danger/board.h +++ b/src/mainboard/google/veyron_danger/board.h @@ -26,6 +26,6 @@ #define GPIO_BACKLIGHT GPIO(7, A, 3) #define GPIO_RESET GPIO(0, B, 5) -/* TODO: move setup_chromeos_gpios() here once bootblock code is in mainboard */ +void setup_chromeos_gpios(void); #endif /* __MAINBOARD_GOOGLE_VEYRON_BRAIN_BOARD_H */ diff --git a/src/mainboard/google/veyron_jerry/board.h b/src/mainboard/google/veyron_jerry/board.h index 3d567ded68..2f8a341d4f 100644 --- a/src/mainboard/google/veyron_jerry/board.h +++ b/src/mainboard/google/veyron_jerry/board.h @@ -26,6 +26,6 @@ #define GPIO_BACKLIGHT GPIO(7, A, 0) #define GPIO_RESET GPIO(0, B, 5) -/* TODO: move setup_chromeos_gpios() here once bootblock code is in mainboard */ +void setup_chromeos_gpios(void); #endif /* __MAINBOARD_GOOGLE_VEYRON_JERRY_BOARD_H */ diff --git a/src/mainboard/google/veyron_mighty/board.h b/src/mainboard/google/veyron_mighty/board.h index 280568a43f..2ca1a41392 100644 --- a/src/mainboard/google/veyron_mighty/board.h +++ b/src/mainboard/google/veyron_mighty/board.h @@ -26,6 +26,6 @@ #define GPIO_BACKLIGHT GPIO(7, A, 0) #define GPIO_RESET GPIO(0, B, 5) -/* TODO: move setup_chromeos_gpios() here once bootblock code is in mainboard */ +void setup_chromeos_gpios(void); #endif /* __MAINBOARD_GOOGLE_VEYRON_MIGHTY_BOARD_H */ diff --git a/src/mainboard/google/veyron_pinky/board.h b/src/mainboard/google/veyron_pinky/board.h index 8fe102fd26..45590e7a57 100644 --- a/src/mainboard/google/veyron_pinky/board.h +++ b/src/mainboard/google/veyron_pinky/board.h @@ -26,6 +26,6 @@ #define GPIO_BACKLIGHT GPIO(7, A, 0) #define GPIO_RESET (board_id() > 0 ? GPIO(0, B, 5) : GPIO(0, B, 2)) -/* TODO: move setup_chromeos_gpios() here once bootblock code is in mainboard */ +void setup_chromeos_gpios(void); #endif /* __MAINBOARD_GOOGLE_VEYRON_PINKY_BOARD_H */ diff --git a/src/mainboard/google/veyron_rialto/board.h b/src/mainboard/google/veyron_rialto/board.h index 7cd8da69ec..7c6fa3725e 100644 --- a/src/mainboard/google/veyron_rialto/board.h +++ b/src/mainboard/google/veyron_rialto/board.h @@ -25,6 +25,6 @@ #define GPIO_RESET GPIO(0, B, 5) -/* TODO: move setup_chromeos_gpios() here once bootblock code is in mainboard */ +void setup_chromeos_gpios(void); #endif /* __MAINBOARD_GOOGLE_VEYRON_RIALTO_BOARD_H */ diff --git a/src/mainboard/google/veyron_speedy/board.h b/src/mainboard/google/veyron_speedy/board.h index 817aac2981..f98854e168 100644 --- a/src/mainboard/google/veyron_speedy/board.h +++ b/src/mainboard/google/veyron_speedy/board.h @@ -26,6 +26,6 @@ #define GPIO_BACKLIGHT GPIO(7, A, 0) #define GPIO_RESET GPIO(0, B, 5) -/* TODO: move setup_chromeos_gpios() here once bootblock code is in mainboard */ +void setup_chromeos_gpios(void); #endif /* __MAINBOARD_GOOGLE_VEYRON_SPEEDY_BOARD_H */ diff --git a/src/vendorcode/google/chromeos/chromeos.h b/src/vendorcode/google/chromeos/chromeos.h index 13a4fe3503..1184fa573e 100644 --- a/src/vendorcode/google/chromeos/chromeos.h +++ b/src/vendorcode/google/chromeos/chromeos.h @@ -26,9 +26,6 @@ #include "vboot_common.h" #include "vboot2/misc.h" -/*for mainboard use only*/ -void setup_chromeos_gpios(void); - /* functions implemented in vbnv.c: */ int get_recovery_mode_from_vbnv(void); int vboot_wants_oprom(void); -- cgit v1.2.3