From cefee5e40f4e7567b25bce9df786a0fbf594a268 Mon Sep 17 00:00:00 2001 From: Felix Held Date: Sat, 23 Oct 2021 00:43:07 +0200 Subject: soc/intel/quark/Kconfig: don't unselect CPU_X86_LAPIC The Intel Quark SoC does have a LAPIC on its x86 CPU core, so we should select CPU_X86_LAPIC. This will additionally include the Makefile from cpu/x86/lapic. Since none of AP_IN_SIPI_WAIT, LEGACY_SMP_INIT and UDELAY_LAPIC gets selected, only the boot_cpu.c and lapic.c targets will be added to the build. Since SMP isn't set, adding the boot_cpu.c target won't change the resulting binary of a timeless build, since the only function inside will be removed by the compiler's pre-processor in the !SMP case. So the only thing that will change the resulting binary is the addition of the lapic.c target. From this target only the function cpu_get_lapic_addr will be used which overrides the weak implementation in acpi/acpi.c. The call in arch/x86/mpspec.c can be ignored, since GENERATE_MP_TABLE isn't selected. So this change will result in the LAPIC address in the MADT being changed from 0 to to LAPIC_DEFAULT_BASE. Since the documentation of the Quark SoC mentions that it has a LAPIC on its one x86 core, this should work. TEST=None Signed-off-by: Felix Held Change-Id: I2f163bd608f0548abb0e8de90843d2a796b8ef6c Reviewed-on: https://review.coreboot.org/c/coreboot/+/58550 Tested-by: build bot (Jenkins) Reviewed-by: Marshall Dawson Reviewed-by: Angel Pons --- src/soc/intel/quark/Kconfig | 4 ---- 1 file changed, 4 deletions(-) (limited to 'src') diff --git a/src/soc/intel/quark/Kconfig b/src/soc/intel/quark/Kconfig index bf9d475cd5..1a9bfef942 100644 --- a/src/soc/intel/quark/Kconfig +++ b/src/soc/intel/quark/Kconfig @@ -24,10 +24,6 @@ config CPU_SPECIFIC_OPTIONS select USE_MARCH_586 select NO_SMM -config CPU_X86_LAPIC - bool - default n - ##### # Debug serial output # The following options configure the debug serial port -- cgit v1.2.3