From cee3abdbaf11d3bd7bb4982dabe623d08729c8d8 Mon Sep 17 00:00:00 2001 From: Sean Rhodes Date: Fri, 12 Aug 2022 15:54:10 +0100 Subject: mb/starlabs/starbook/kbl: Update verb table The ALC269 does not support the hardware equaliser, so remove the entries related to this, as they have no effect. Revert to the ALC269 defaults which work correctly with Linux. This also corrects the subsystem id from 0x10ec111e to 0x10ec10d0. Signed-off-by: Sean Rhodes Change-Id: I82647f67730ec344591f7dbd759a421c116d4fdd Reviewed-on: https://review.coreboot.org/c/coreboot/+/66687 Tested-by: build bot (Jenkins) Reviewed-by: Matt DeVillier Reviewed-by: Angel Pons --- .../starlabs/starbook/variants/kbl/hda_verb.c | 150 ++------------------- 1 file changed, 9 insertions(+), 141 deletions(-) (limited to 'src') diff --git a/src/mainboard/starlabs/starbook/variants/kbl/hda_verb.c b/src/mainboard/starlabs/starbook/variants/kbl/hda_verb.c index f09f37b094..9c023897f0 100644 --- a/src/mainboard/starlabs/starbook/variants/kbl/hda_verb.c +++ b/src/mainboard/starlabs/starbook/variants/kbl/hda_verb.c @@ -5,20 +5,20 @@ const u32 cim_verb_data[] = { /* coreboot specific header */ 0x10ec0269, /* Codec Vendor / Device ID: Realtek ALC269 */ - 0x10ec111e, /* Subsystem ID */ - 36, /* Number of jacks (NID entries) */ + 0x10ec10d0, /* Subsystem ID */ + 18, /* Number of jacks (NID entries) */ /* Reset Codec First */ AZALIA_RESET(0x1), /* HDA Codec Subsystem ID Verb-table */ - AZALIA_SUBVENDOR(0, 0x10ec111e), + AZALIA_SUBVENDOR(0, 0x10ec10d0), /* Pin Widget Verb-table */ AZALIA_PIN_CFG(0, 0x01, 0x00000000), AZALIA_PIN_CFG(0, 0x12, 0x90a61120), AZALIA_PIN_CFG(0, 0x14, 0x90171110), - AZALIA_PIN_CFG(0, 0x15, 0x042B1010), + AZALIA_PIN_CFG(0, 0x15, 0x04ab1020), AZALIA_PIN_CFG(0, 0x17, 0x411111F0), AZALIA_PIN_CFG(0, 0x18, 0x04AB1020), AZALIA_PIN_CFG(0, 0x19, 0x411111F0), @@ -27,31 +27,19 @@ const u32 cim_verb_data[] = { AZALIA_PIN_CFG(0, 0x1D, 0x411111F0), AZALIA_PIN_CFG(0, 0x1E, 0x411111F0), - /* Reset to D0 */ - 0x00170500, - 0x00170500, - 0x00170500, - 0x00170500, - - /* Reset Register */ - 0x0205001A, - 0x02048003, - 0x0205001A, - 0x0204C003, - - /* Widget node 0x20 */ + /* ALC269 Default 1 */ 0x02050018, - 0x02040184, /* Stock: 0x02043984 */ + 0x02043984, 0x0205001C, 0x02040800, - /* ALC269 Default 1 */ + /* ALC269 Default 2 */ 0x02050024, 0x02040000, 0x02050004, 0x02040080, - /* ALC269 Default 2 */ + /* ALC269 Default 3 */ 0x02050008, 0x02040300, 0x0205000C, @@ -63,132 +51,12 @@ const u32 cim_verb_data[] = { 0x02050015, 0x02048002, - /* ALC269 Default 4 */ + /* ALC269 Default 5 */ 0x00C37080, 0x00270610, 0x00D37080, 0x00370610, - /* - * Equalizer: - * - * AGC - * Threshold: - 6.00 dB - * Front Boost: + 6.00 dB - * Post Boost: + 6.00 dB - * - * Low Pass Filter - * Boost Gain: Enabled - * BW: 200Hz - * Gain: + 4.00 dB - * - * Band Pass Filter 1 - * Fc: 240Hz - * BW: 400Hz - * Gain: - 4.00 dB - * - * Band Pass Filter 2 - * Fc: 16000Hz - * BW: 1000Hz - * Gain: + 12.00 dB - * - * High Pass Filter - * Boost Gain: Enabled - * BW: 200Hz - * Gain: - 4.00 dB - * - * Class D Amp - * Power: 2.5W - * Resistance: 4ohms - * - * EQ Output - * Left: + 0.00 dB - * Right: + 0.00 dB - * - * VARQ - * Q: 0.707 - */ - - 0x05350000, - 0x053404DA, - 0x0535001d, - 0x05340800, - - 0x0535001e, - 0x05340800, - 0x05350003, - 0x05341F7A, - - 0x05350004, - 0x0534FA18, - 0x0535000F, - 0x0534C295, - - 0x05350010, - 0x05341D73, - 0x05350011, - 0x0534FA18, - - 0x05350012, - 0x05341E08, - 0x05350013, - 0x05341C10, - - 0x05350014, - 0x05342FB2, - 0x0535001B, - 0x05341F2C, - - 0x0535001C, - 0x0534095C, - 0x05450000, - 0x05440000, - - 0x0545001d, - 0x05440800, - 0x0545001e, - 0x05440800, - - 0x05450003, - 0x05441F7A, - 0x05450004, - 0x0544FA18, - - 0x0545000F, - 0x0544C295, - 0x05450010, - 0x05441D73, - - 0x05450011, - 0x0544FA18, - 0x05450012, - 0x05441E08, - - 0x05450013, - 0x05441C10, - 0x05450014, - 0x05442FB2, - - 0x0545001B, - 0x05441F2C, - 0x0545001C, - 0x0544095C, - - 0x05350000, - 0x0534C4DA, - 0x02050038, - 0x02044901, - - 0x02050013, - 0x0204422F, - 0x02050016, - 0x02044E50, - - 0x02050012, - 0x0204EBC4, - 0x02050020, - 0x020451FF, - 0x8086280b, /* Codec Vendor / Device ID: Intel */ 0x80860101, /* Subsystem ID */ 4, /* Number of 4 dword sets */ -- cgit v1.2.3