From cd8771640feb4c5d05104bae26134b20f7e8c9f6 Mon Sep 17 00:00:00 2001 From: Felix Held Date: Thu, 3 Feb 2022 19:09:39 +0100 Subject: soc/amd/sabrina/include/amd_pci_int_defs.h: remove PIRQ_SATA Sabrina has no SATA controller, so remove the corresponding PIRQ mapping. This was verified with PPR #57243 Rev 1.53. Signed-off-by: Felix Held Change-Id: I98ffa3675c361e8a74c50ebfc37e79ae63dacc85 Reviewed-on: https://review.coreboot.org/c/coreboot/+/61601 Tested-by: build bot (Jenkins) Reviewed-by: Raul Rangel --- src/mainboard/amd/chausie/mainboard.c | 1 - src/soc/amd/sabrina/fch.c | 1 - src/soc/amd/sabrina/include/soc/amd_pci_int_defs.h | 6 +----- 3 files changed, 1 insertion(+), 7 deletions(-) (limited to 'src') diff --git a/src/mainboard/amd/chausie/mainboard.c b/src/mainboard/amd/chausie/mainboard.c index d667f5aeed..073c168677 100644 --- a/src/mainboard/amd/chausie/mainboard.c +++ b/src/mainboard/amd/chausie/mainboard.c @@ -48,7 +48,6 @@ static const struct fch_irq_routing { { PIRQ_SCI, ACPI_SCI_IRQ, ACPI_SCI_IRQ }, { PIRQ_SD, PIRQ_NC, PIRQ_NC }, { PIRQ_SDIO, PIRQ_NC, PIRQ_NC }, - { PIRQ_SATA, PIRQ_NC, PIRQ_NC }, { PIRQ_EMMC, PIRQ_NC, PIRQ_NC }, { PIRQ_GPIO, 7, 7 }, { PIRQ_I2C2, PIRQ_NC, PIRQ_NC }, diff --git a/src/soc/amd/sabrina/fch.c b/src/soc/amd/sabrina/fch.c index 69149f06e5..9be7dd8912 100644 --- a/src/soc/amd/sabrina/fch.c +++ b/src/soc/amd/sabrina/fch.c @@ -52,7 +52,6 @@ const static struct irq_idx_name irq_association[] = { { PIRQ_GPIOA, "GPIOa" }, { PIRQ_GPIOB, "GPIOb" }, { PIRQ_GPIOC, "GPIOc" }, - { PIRQ_SATA, "SATA" }, { PIRQ_EMMC, "eMMC" }, { PIRQ_GPP0, "GPP0" }, { PIRQ_GPP1, "GPP1" }, diff --git a/src/soc/amd/sabrina/include/soc/amd_pci_int_defs.h b/src/soc/amd/sabrina/include/soc/amd_pci_int_defs.h index a3f8b82ddc..424b2245d3 100644 --- a/src/soc/amd/sabrina/include/soc/amd_pci_int_defs.h +++ b/src/soc/amd/sabrina/include/soc/amd_pci_int_defs.h @@ -1,7 +1,5 @@ /* SPDX-License-Identifier: GPL-2.0-only */ -/* TODO: Check if this is still correct */ - #ifndef AMD_SABRINA_AMD_PCI_INT_DEFS_H #define AMD_SABRINA_AMD_PCI_INT_DEFS_H @@ -40,9 +38,7 @@ #define PIRQ_GPIOA 0x21 /* GPIOa from PAD_FANIN0 */ #define PIRQ_GPIOB 0x22 /* GPIOb from PAD_FANOUT0 */ #define PIRQ_GPIOC 0x23 /* GPIOc no IRQ connected */ -/* 0x24-0x40 reserved */ -#define PIRQ_SATA 0x41 /* SATA */ -/* 0x42 reserved */ +/* 0x24-0x42 reserved */ #define PIRQ_EMMC 0x43 /* eMMC */ /* 0x44-0x4f reserved */ #define PIRQ_GPP0 0x50 /* GPPInt0 */ -- cgit v1.2.3