From c7e5d798420bb00f2c1853ca6abc11a7ee027886 Mon Sep 17 00:00:00 2001 From: David Hendricks Date: Sun, 7 Apr 2013 17:38:32 -0700 Subject: exynos5250: add missing address-of operator in UART driver This adds a missing address-of operator. This was a subtle bug that didn't seem to cause problems at first since the serial console appeared to work. However it caused an imprecise external abort which became apparent later on when aborts were unmasked in the kernel via the CPSR_A bit. (credit goes to Gabe Black for finding this) Signed-off-by: Gabe Black Signed-off-by: David Hendricks Change-Id: I80a33b147d92d559fa8fefbe7d5642235deb9aea Reviewed-on: http://review.coreboot.org/3038 Tested-by: build bot (Jenkins) Reviewed-by: Ronald G. Minnich --- src/cpu/samsung/exynos5250/uart.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'src') diff --git a/src/cpu/samsung/exynos5250/uart.c b/src/cpu/samsung/exynos5250/uart.c index d23087a8b1..75c576332f 100644 --- a/src/cpu/samsung/exynos5250/uart.c +++ b/src/cpu/samsung/exynos5250/uart.c @@ -185,7 +185,7 @@ static void exynos5_uart_tx_byte(unsigned char data) struct s5p_uart *uart = (struct s5p_uart *)base_port; /* wait for room in the tx FIFO */ - while ((readl(uart->ufstat) & TX_FIFO_FULL_MASK)) { + while ((readl(&uart->ufstat) & TX_FIFO_FULL_MASK)) { if (exynos5_uart_err_check(1)) return; } -- cgit v1.2.3