From bce7458aa18a1924ba072a5a3cd966ff88fffb77 Mon Sep 17 00:00:00 2001 From: Arthur Heymans Date: Wed, 27 Oct 2021 13:43:03 +0200 Subject: acpi/acpigen.c: Remove weak gpio definition Compiletime errors > runtime errors. Change-Id: I1db0a8f01eaecf012e5444c03f8d4e2bb6e42a77 Signed-off-by: Arthur Heymans Reviewed-on: https://review.coreboot.org/c/coreboot/+/58649 Tested-by: build bot (Jenkins) Reviewed-by: Tim Wawrzynczak Reviewed-by: Felix Held --- src/acpi/acpigen.c | 29 ----------------------------- 1 file changed, 29 deletions(-) (limited to 'src') diff --git a/src/acpi/acpigen.c b/src/acpi/acpigen.c index 37bfec1654..2b74261a2f 100644 --- a/src/acpi/acpigen.c +++ b/src/acpi/acpigen.c @@ -2020,35 +2020,6 @@ void acpigen_write_rom(void *bios, const size_t length) acpigen_pop_len(); } -/* Soc-implemented functions -- weak definitions. */ -int __weak acpigen_soc_read_rx_gpio(unsigned int gpio_num) -{ - printk(BIOS_ERR, "ERROR: %s not implemented\n", __func__); - acpigen_write_debug_string("read_rx_gpio not available"); - return -1; -} - -int __weak acpigen_soc_get_tx_gpio(unsigned int gpio_num) -{ - printk(BIOS_ERR, "ERROR: %s not implemented\n", __func__); - acpigen_write_debug_string("get_tx_gpio not available"); - return -1; -} - -int __weak acpigen_soc_set_tx_gpio(unsigned int gpio_num) -{ - printk(BIOS_ERR, "ERROR: %s not implemented\n", __func__); - acpigen_write_debug_string("set_tx_gpio not available"); - return -1; -} - -int __weak acpigen_soc_clear_tx_gpio(unsigned int gpio_num) -{ - printk(BIOS_ERR, "ERROR: %s not implemented\n", __func__); - acpigen_write_debug_string("clear_tx_gpio not available"); - return -1; -} - /* * Helper functions for enabling/disabling Tx GPIOs based on the GPIO * polarity. These functions end up calling acpigen_soc_{set,clear}_tx_gpio to -- cgit v1.2.3