From bc3150913beec4d35081edd05ba8d54d36d31f64 Mon Sep 17 00:00:00 2001 From: Stefan Reinauer Date: Tue, 27 Jun 2017 00:46:22 +0200 Subject: northbridge/amd/pi: Arithmetics is not logic It's pretty obvious that the author did not want to use a logical and (&&) here but an arithmetical and (&) Change-Id: Ic1bece86986906b76308bbb46235c22418e27990 Signed-off-by: Stefan Reinauer Reviewed-on: https://review.coreboot.org/20388 Tested-by: build bot (Jenkins) Reviewed-by: Paul Menzel Reviewed-by: Patrick Georgi --- src/northbridge/amd/pi/00660F01/northbridge.c | 2 +- src/northbridge/amd/pi/00670F00/northbridge.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) (limited to 'src') diff --git a/src/northbridge/amd/pi/00660F01/northbridge.c b/src/northbridge/amd/pi/00660F01/northbridge.c index f085d5c20d..bd4884c466 100644 --- a/src/northbridge/amd/pi/00660F01/northbridge.c +++ b/src/northbridge/amd/pi/00660F01/northbridge.c @@ -869,7 +869,7 @@ static void cpu_bus_scan(device_t dev) AmdGetValue(AMD_GLOBAL_USER_OPTIONS, (VOID**)&options, sizeof(options)); AmdGetValue(AMD_GLOBAL_NUM_MODULES, &modules_ptr, sizeof(modules)); - modules = (*(u32*)modules_ptr) && ((1ull << (sizeof(modules) * 8)) - 1); + modules = (*(u32 *)modules_ptr) & ((1ull << (sizeof(modules) * 8)) - 1); ASSERT(modules > 0); ASSERT(options); ioapic_count = (int)options->CfgPlatNumIoApics; diff --git a/src/northbridge/amd/pi/00670F00/northbridge.c b/src/northbridge/amd/pi/00670F00/northbridge.c index 006bc48a6e..f8be67d85d 100644 --- a/src/northbridge/amd/pi/00670F00/northbridge.c +++ b/src/northbridge/amd/pi/00670F00/northbridge.c @@ -878,7 +878,7 @@ static void cpu_bus_scan(device_t dev) AmdGetValue(AMD_GLOBAL_USER_OPTIONS, (VOID**)&options, sizeof(options)); AmdGetValue(AMD_GLOBAL_NUM_MODULES, &modules_ptr, sizeof(modules)); - modules = (*(u32*)modules_ptr) && ((1ull << (sizeof(modules) * 8)) - 1); + modules = (*(u32 *)modules_ptr) & ((1ull << (sizeof(modules) * 8)) - 1); ASSERT(modules > 0); ASSERT(options); ioapic_count = (int)options->CfgPlatNumIoApics; -- cgit v1.2.3