From b66907ac16394e8d2eb4194199fd65a5c66e49fd Mon Sep 17 00:00:00 2001 From: Patrick Rudolph Date: Wed, 7 Nov 2018 15:23:40 +0100 Subject: drivers/spi: Return error in failure case In case the function pointer isn't set return an error. Change-Id: I9de300f651ac93889dafa7377c876bf5ae2c50cc Signed-off-by: Patrick Rudolph Reviewed-on: https://review.coreboot.org/29531 Tested-by: build bot (Jenkins) Reviewed-by: Philipp Deppenwiese --- src/drivers/spi/spi_flash.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'src') diff --git a/src/drivers/spi/spi_flash.c b/src/drivers/spi/spi_flash.c index cc21ccb20e..b0b58993a6 100644 --- a/src/drivers/spi/spi_flash.c +++ b/src/drivers/spi/spi_flash.c @@ -448,7 +448,7 @@ int spi_flash_is_write_protected(const struct spi_flash *flash, if (!flash->ops->get_write_protection) { printk(BIOS_WARNING, "SPI: Write-protection gathering not " "implemented for this vendor.\n"); - return 0; + return -1; } return flash->ops->get_write_protection(flash, region); @@ -473,7 +473,7 @@ int spi_flash_set_write_protected(const struct spi_flash *flash, if (!flash->ops->set_write_protection) { printk(BIOS_WARNING, "SPI: Setting write-protection is not " "implemented for this vendor.\n"); - return 0; + return -1; } ret = flash->ops->set_write_protection(flash, region, non_volatile, -- cgit v1.2.3