From b4e3408967a61c425ae27690af2fc23a79a94816 Mon Sep 17 00:00:00 2001 From: Felix Held <felix-coreboot@felixheld.de> Date: Wed, 30 Mar 2022 22:47:00 +0200 Subject: soc/amd/common/block/i2c/i23c_pad_ctrl: invert and mask When masking out bits with an and mask, the bit mask needs to be inverted. Signed-off-by: Felix Held <felix-coreboot@felixheld.de> Change-Id: I9739d7150e230fbbe6523413de9c07d7340f3c61 Reviewed-on: https://review.coreboot.org/c/coreboot/+/63222 Reviewed-by: Karthik Ramasubramanian <kramasub@google.com> Reviewed-by: Fred Reitberger <reitbergerfred@gmail.com> Tested-by: build bot (Jenkins) <no-reply@coreboot.org> --- src/soc/amd/common/block/i2c/i23c_pad_ctrl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'src') diff --git a/src/soc/amd/common/block/i2c/i23c_pad_ctrl.c b/src/soc/amd/common/block/i2c/i23c_pad_ctrl.c index 36211a3264..243905417e 100644 --- a/src/soc/amd/common/block/i2c/i23c_pad_ctrl.c +++ b/src/soc/amd/common/block/i2c/i23c_pad_ctrl.c @@ -48,7 +48,7 @@ void fch_i23c_pad_init(unsigned int bus, pad_ctrl |= speed == I2C_SPEED_STANDARD ? I23C_PAD_CTRL_FALLSLEW_SEL_STD : I23C_PAD_CTRL_FALLSLEW_SEL_LOW; - pad_ctrl &= I23C_PAD_CTRL_SLEW_N_MASK; + pad_ctrl &= ~I23C_PAD_CTRL_SLEW_N_MASK; pad_ctrl |= I23C_PAD_CTRL_SLEW_N_FAST; misc_write32(MISC_I23C_PAD_CTRL(bus), pad_ctrl); -- cgit v1.2.3