From b33816e171ad111bd089979427a5eaaf6890a3f0 Mon Sep 17 00:00:00 2001 From: Felix Held Date: Fri, 3 Sep 2021 16:18:28 +0200 Subject: drivers/intel/fsp2_0: add warning when ADD_FSP_BINARIES isn't selected Platforms that rely on the FSP for parts of the hardware initialization likely won't boot successfully when no FSP binaries are added during the build, so print a warning at the end of the build in this case. Signed-off-by: Felix Held Suggested-by: Nico Huber Suggested-by: Martin Roth Change-Id: I6efc184ecc4059818474937fd31574f703c9bdc6 Reviewed-on: https://review.coreboot.org/c/coreboot/+/57368 Tested-by: build bot (Jenkins) Reviewed-by: Nico Huber --- src/drivers/intel/fsp2_0/Makefile.inc | 9 +++++++++ 1 file changed, 9 insertions(+) (limited to 'src') diff --git a/src/drivers/intel/fsp2_0/Makefile.inc b/src/drivers/intel/fsp2_0/Makefile.inc index 80dc93b75e..01b4c9ec1d 100644 --- a/src/drivers/intel/fsp2_0/Makefile.inc +++ b/src/drivers/intel/fsp2_0/Makefile.inc @@ -110,8 +110,17 @@ endif # CONFIG_FSP_M_FILE ifeq ($(call strip_quotes,$(CONFIG_FSP_S_FILE)),) $(error No FSP-S binary file specified.) endif # CONFIG_FSP_S_FILE +else # CONFIG_ADD_FSP_BINARIES +build_complete:: warn_no_fsp_binaries endif # CONFIG_ADD_FSP_BINARIES +PHONY+=warn_no_fsp_binaries +warn_no_fsp_binaries: + printf "\n\t** WARNING **\n" + printf "ADD_FSP_BINARIES isn't selected even though this SoC relies on the FSP.\n" + printf "The resulting image won't contain the FSP binaries and will not boot unless\n" + printf "they are added later.\n" + subdirs-y += ppi endif -- cgit v1.2.3