From a6562bd221b42b22bbd9f85326f6631a3c51dd5c Mon Sep 17 00:00:00 2001 From: Robert Zieba Date: Fri, 18 Mar 2022 14:30:01 -0600 Subject: mb/google/guybrush/var/dewatt: Use exclusive SPD IDs for Samsung parts Parts K4U6E3S4AB-MGCL and K4UBE3D4AB-MGCL require special handling. This commit assigns them exclusive IDs 9 and 11 to facilitate this. BUG=b:224884904 Signed-off-by: Robert Zieba Change-Id: I01ea1442b20849a404cf397614c25a441cc84c4b Reviewed-on: https://review.coreboot.org/c/coreboot/+/62930 Tested-by: build bot (Jenkins) Reviewed-by: Karthik Ramasubramanian --- .../google/guybrush/variants/dewatt/memory/Makefile.inc | 12 ++++++++++-- .../guybrush/variants/dewatt/memory/dram_id.generated.txt | 4 ++-- .../guybrush/variants/dewatt/memory/mem_parts_used.txt | 4 ++-- 3 files changed, 14 insertions(+), 6 deletions(-) (limited to 'src') diff --git a/src/mainboard/google/guybrush/variants/dewatt/memory/Makefile.inc b/src/mainboard/google/guybrush/variants/dewatt/memory/Makefile.inc index 02eafcb317..c4e409dda9 100644 --- a/src/mainboard/google/guybrush/variants/dewatt/memory/Makefile.inc +++ b/src/mainboard/google/guybrush/variants/dewatt/memory/Makefile.inc @@ -5,6 +5,14 @@ SPD_SOURCES = SPD_SOURCES += spd/lp4x/set-1/spd-4.hex # ID = 0(0b0000) Parts = MT53E1G32D2NP-046 WT:A -SPD_SOURCES += spd/lp4x/set-1/spd-1.hex # ID = 1(0b0001) Parts = MT53E512M32D2NP-046 WT:F, H9HCNNNBKMMLXR-NEE, MT53E512M32D2NP-046 WT:E, K4U6E3S4AA-MGCR, K4U6E3S4AB-MGCL, H54G46CYRBX267, MT53E512M32D1NP-046 WT:B +SPD_SOURCES += spd/lp4x/set-1/spd-1.hex # ID = 1(0b0001) Parts = MT53E512M32D2NP-046 WT:F, H9HCNNNBKMMLXR-NEE, MT53E512M32D2NP-046 WT:E, K4U6E3S4AA-MGCR, H54G46CYRBX267, MT53E512M32D1NP-046 WT:B SPD_SOURCES += spd/lp4x/set-1/spd-9.hex # ID = 2(0b0010) Parts = NT6AP256T32AV-J1 -SPD_SOURCES += spd/lp4x/set-1/spd-3.hex # ID = 3(0b0011) Parts = MT53E1G32D2NP-046 WT:B, H9HCNNNCPMMLXR-NEE, K4UBE3D4AA-MGCR, H54G56CYRBX247, K4UBE3D4AB-MGCL +SPD_SOURCES += spd/lp4x/set-1/spd-3.hex # ID = 3(0b0011) Parts = MT53E1G32D2NP-046 WT:B, H9HCNNNCPMMLXR-NEE, K4UBE3D4AA-MGCR, H54G56CYRBX247 +SPD_SOURCES += spd/lp4x/set-1/spd-empty.hex # ID = 4(0b0100) +SPD_SOURCES += spd/lp4x/set-1/spd-empty.hex # ID = 5(0b0101) +SPD_SOURCES += spd/lp4x/set-1/spd-empty.hex # ID = 6(0b0110) +SPD_SOURCES += spd/lp4x/set-1/spd-empty.hex # ID = 7(0b0111) +SPD_SOURCES += spd/lp4x/set-1/spd-empty.hex # ID = 8(0b1000) +SPD_SOURCES += spd/lp4x/set-1/spd-1.hex # ID = 9(0b1001) Parts = K4U6E3S4AB-MGCL +SPD_SOURCES += spd/lp4x/set-1/spd-empty.hex # ID = 10(0b1010) +SPD_SOURCES += spd/lp4x/set-1/spd-3.hex # ID = 11(0b1011) Parts = K4UBE3D4AB-MGCL diff --git a/src/mainboard/google/guybrush/variants/dewatt/memory/dram_id.generated.txt b/src/mainboard/google/guybrush/variants/dewatt/memory/dram_id.generated.txt index d574a6f474..48d94b3e6c 100644 --- a/src/mainboard/google/guybrush/variants/dewatt/memory/dram_id.generated.txt +++ b/src/mainboard/google/guybrush/variants/dewatt/memory/dram_id.generated.txt @@ -13,8 +13,8 @@ MT53E512M32D2NP-046 WT:E 1 (0001) K4U6E3S4AA-MGCR 1 (0001) H9HCNNNCPMMLXR-NEE 3 (0011) K4UBE3D4AA-MGCR 3 (0011) -K4U6E3S4AB-MGCL 1 (0001) +K4U6E3S4AB-MGCL 9 (1001) H54G46CYRBX267 1 (0001) MT53E512M32D1NP-046 WT:B 1 (0001) H54G56CYRBX247 3 (0011) -K4UBE3D4AB-MGCL 3 (0011) +K4UBE3D4AB-MGCL 11 (1011) diff --git a/src/mainboard/google/guybrush/variants/dewatt/memory/mem_parts_used.txt b/src/mainboard/google/guybrush/variants/dewatt/memory/mem_parts_used.txt index 298e58b569..9d79210a22 100644 --- a/src/mainboard/google/guybrush/variants/dewatt/memory/mem_parts_used.txt +++ b/src/mainboard/google/guybrush/variants/dewatt/memory/mem_parts_used.txt @@ -7,8 +7,8 @@ MT53E512M32D2NP-046 WT:E K4U6E3S4AA-MGCR H9HCNNNCPMMLXR-NEE K4UBE3D4AA-MGCR -K4U6E3S4AB-MGCL +K4U6E3S4AB-MGCL,*9 H54G46CYRBX267 MT53E512M32D1NP-046 WT:B H54G56CYRBX247 -K4UBE3D4AB-MGCL +K4UBE3D4AB-MGCL,*11 -- cgit v1.2.3