From a2248cbf9ab1de22862a73e1d52d5a2361d55c51 Mon Sep 17 00:00:00 2001 From: Patrick Georgi Date: Fri, 22 Sep 2017 18:21:52 +0200 Subject: device/dram/ddr2: Add break to several case statements that lack it MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit For all valid SPD values the same decoded tRR was returned. Change-Id: Iec43f8c7460dfcf68f7c92dfdf333b004f368b65 Signed-off-by: Patrick Georgi Found-by: Coverity Scan #1381369, #1381370, 1381371, 1381372, 1381373 Reviewed-on: https://review.coreboot.org/21642 Tested-by: build bot (Jenkins) Reviewed-by: Kyösti Mälkki Reviewed-by: Arthur Heymans Reviewed-by: Nico Huber --- src/device/dram/ddr2.c | 6 ++++++ 1 file changed, 6 insertions(+) (limited to 'src') diff --git a/src/device/dram/ddr2.c b/src/device/dram/ddr2.c index 6f43563b6e..2dab681754 100644 --- a/src/device/dram/ddr2.c +++ b/src/device/dram/ddr2.c @@ -194,16 +194,22 @@ static int spd_decode_tRR_time(u32 *tRR, u8 c) return CB_ERR; case 0x80: *tRR = 15625 << 8; + break; case 0x81: *tRR = 15625 << 6; + break; case 0x82: *tRR = 15625 << 7; + break; case 0x83: *tRR = 15625 << 9; + break; case 0x84: *tRR = 15625 << 10; + break; case 0x85: *tRR = 15625 << 11; + break; } return CB_SUCCESS; } -- cgit v1.2.3