From 9fd5c69b79765714507aea48384bb4b61a57ea2b Mon Sep 17 00:00:00 2001 From: Naresh Solanki Date: Mon, 22 May 2023 16:47:47 +0200 Subject: soc/intel/xeon_sp: Clear reserved field in SRAT During the ACPI dump of the System Resource Affinity Table (SRAT), it was noticed that the reserved field within the Memory Affinity structure contained a non-zero value. This commit addresses the issue by performing a memset to zero on the reserved field, ensuring the avoidance of any potential problems arising from garbage values. TEST= Build for ibm/sbp1 & make sure SRAT Memory Affinity entries reserved fields read zeroes Signed-off-by: Naresh Solanki Change-Id: I4ba697a6bd59054e74c84b98f3d9b517d333a5d8 Reviewed-on: https://review.coreboot.org/c/coreboot/+/75417 Reviewed-by: Felix Held Tested-by: build bot (Jenkins) Reviewed-by: Patrick Rudolph --- src/soc/intel/xeon_sp/uncore_acpi.c | 1 + 1 file changed, 1 insertion(+) (limited to 'src') diff --git a/src/soc/intel/xeon_sp/uncore_acpi.c b/src/soc/intel/xeon_sp/uncore_acpi.c index e2b262e04d..2cc3c8fb92 100644 --- a/src/soc/intel/xeon_sp/uncore_acpi.c +++ b/src/soc/intel/xeon_sp/uncore_acpi.c @@ -149,6 +149,7 @@ static unsigned long acpi_fill_srat(unsigned long current) /* create all subtables for processors */ current = acpi_create_srat_lapics(current); + memset(srat_mem, 0, sizeof(srat_mem)); mem_count = get_srat_memory_entries(srat_mem); for (int i = 0; i < mem_count; ++i) { printk(BIOS_DEBUG, "adding srat memory %d entry length: %d, addr: 0x%x%x, " -- cgit v1.2.3