From 9adf4a6656c609beec7a9ecd2615aade1ecf8caa Mon Sep 17 00:00:00 2001 From: Raul E Rangel Date: Thu, 22 Jul 2021 12:25:35 -0600 Subject: lib/thread: Add asserts around stack size and alignment `cpu_info()` requires that stacks be STACK_SIZE aligned and a power of 2. BUG=b:179699789 TEST=Boot guybrush to the OS Signed-off-by: Raul E Rangel Change-Id: I615623f05bfbe2861dcefe5cae66899aec306ba2 Reviewed-on: https://review.coreboot.org/c/coreboot/+/56530 Tested-by: build bot (Jenkins) Reviewed-by: Furquan Shaikh --- src/lib/thread.c | 7 +++++++ 1 file changed, 7 insertions(+) (limited to 'src') diff --git a/src/lib/thread.c b/src/lib/thread.c index 3be2e92f5c..262cfa53bd 100644 --- a/src/lib/thread.c +++ b/src/lib/thread.c @@ -11,6 +11,10 @@ #include #include +/* Can't use the IS_POWER_OF_2 in _Static_assert */ +_Static_assert((CONFIG_STACK_SIZE & (CONFIG_STACK_SIZE - 1)) == 0, + "`cpu_info()` requires the stack size to be a power of 2"); + static bool initialized; static void idle_thread_init(void); @@ -257,6 +261,9 @@ void threads_initialize(void) thread_stacks = arch_get_thread_stackbase(); + /* `cpu_info()` requires the stacks to be STACK_SIZE aligned */ + assert(IS_ALIGNED((uintptr_t)thread_stacks, CONFIG_STACK_SIZE)); + /* Initialize the BSP thread first. The cpu_info structure is assumed * to be just under the top of the stack. */ t = &all_threads[0]; -- cgit v1.2.3