From 9ac0984c5a91b831ac0f0614e604b70b3fa634d0 Mon Sep 17 00:00:00 2001 From: "Chris.Wang" Date: Tue, 13 Dec 2022 14:31:38 +0800 Subject: soc/amd/mendocino: add dptc tablet mode support add dptc support for different power parameter on tablet/clamshell mode. BUG=b:257187831 BRANCH=none TEST=validate the parameter change for each mode by AGT. Signed-off-by: Chris.Wang Change-Id: I96e04d113d18b42f3457056a5e4fa311ceccffb3 Reviewed-on: https://review.coreboot.org/c/coreboot/+/70670 Tested-by: build bot (Jenkins) Reviewed-by: Raul Rangel Reviewed-by: Tim Van Patten Reviewed-by: John Su Reviewed-by: Dtrain Hsu Reviewed-by: Frank Wu --- src/mainboard/google/skyrim/Kconfig | 7 ------- src/soc/amd/mendocino/Kconfig | 14 ++++++++++++++ src/soc/amd/mendocino/chip.h | 3 +++ src/soc/amd/mendocino/root_complex.c | 18 ++++++++++++++++++ 4 files changed, 35 insertions(+), 7 deletions(-) (limited to 'src') diff --git a/src/mainboard/google/skyrim/Kconfig b/src/mainboard/google/skyrim/Kconfig index f171b9ff24..5eee2d617a 100644 --- a/src/mainboard/google/skyrim/Kconfig +++ b/src/mainboard/google/skyrim/Kconfig @@ -164,11 +164,4 @@ config ENABLE_STB_SPILL_TO_DRAM just the small SRAM buffer to a much larger area reserved in main memory. -config FEATURE_DYNAMIC_DPTC - bool - depends on SOC_AMD_COMMON_BLOCK_ACPI_DPTC - help - Selected by mainboards that implement support for ALIB - to enable dynamic DPTC. - endif # BOARD_GOOGLE_BASEBOARD_SKYRIM diff --git a/src/soc/amd/mendocino/Kconfig b/src/soc/amd/mendocino/Kconfig index ef03ec1388..70f81c58e0 100644 --- a/src/soc/amd/mendocino/Kconfig +++ b/src/soc/amd/mendocino/Kconfig @@ -324,6 +324,20 @@ config ACPI_SSDT_PSD_INDEPENDENT cores to transition between p-states independently. A vendor may choose to generate _PSD object to allow cores to transition together. +config FEATURE_DYNAMIC_DPTC + bool + depends on SOC_AMD_COMMON_BLOCK_ACPI_DPTC + help + Selected by mainboards that implement support for ALIB + to enable dynamic DPTC. + +config FEATURE_TABLET_MODE_DPTC + bool + depends on SOC_AMD_COMMON_BLOCK_ACPI_DPTC + help + Selected by mainboards that implement support for ALIB to + switch default and tablet mode. + menu "PSP Configuration Options" config AMD_FWM_POSITION_INDEX diff --git a/src/soc/amd/mendocino/chip.h b/src/soc/amd/mendocino/chip.h index 11121c5522..c206445e58 100644 --- a/src/soc/amd/mendocino/chip.h +++ b/src/soc/amd/mendocino/chip.h @@ -74,6 +74,9 @@ struct soc_amd_mendocino_config { uint32_t vrm_maximum_current_limit_throttle_mA; uint32_t vrm_soc_current_limit_throttle_mA; + /* tablet mode.*/ + uint32_t sustained_power_limit_mW_tablet; + /* Thermal profile B*/ uint32_t fast_ppt_limit_mW_B; uint32_t slow_ppt_limit_mW_B; diff --git a/src/soc/amd/mendocino/root_complex.c b/src/soc/amd/mendocino/root_complex.c index 35fc573c71..f239a42d52 100644 --- a/src/soc/amd/mendocino/root_complex.c +++ b/src/soc/amd/mendocino/root_complex.c @@ -255,6 +255,24 @@ static void acipgen_dptci(void) acpigen_write_alib_dptc_no_battery((uint8_t *)&no_battery_input, sizeof(no_battery_input)); +#if (CONFIG(FEATURE_TABLET_MODE_DPTC)) + struct dptc_input tablet_input = DPTC_INPUTS( + config->thermctl_limit_degreeC, + config->sustained_power_limit_mW_tablet, + config->slow_ppt_time_constant_s, + config->fast_ppt_limit_mW, + config->slow_ppt_limit_mW, + config->vrm_current_limit_mA, + config->vrm_maximum_current_limit_mA, + config->vrm_soc_current_limit_mA, + config->stt_min_limit, + config->stt_m1, + config->stt_m2, + config->stt_c_apu, + config->stt_skin_temp_apu); + acpigen_write_alib_dptc_tablet((uint8_t *)&tablet_input, sizeof(tablet_input)); +#endif + #if (CONFIG(FEATURE_DYNAMIC_DPTC)) /* Profile B */ struct dptc_input thermal_B_input = DPTC_INPUTS( -- cgit v1.2.3