From 971ea286dd2af2af0f8cc3f176d9f9d7ac95d3fe Mon Sep 17 00:00:00 2001 From: Patrick Rudolph Date: Fri, 14 Jul 2023 17:00:17 +0200 Subject: soc/intel/xeon_sp: Print HOB for all sockets Use the FSP define to iterate over all sockets as the runtime value of numofIIO is the detected number of sockets, not the highest working socket. This fixes printing the HOB on multi-socket platforms where a CPU has been removed or has been disabled (4S system running as 3S). Change-Id: Ieed67cd48d26c7634636c0aae6a56f3b6fbdf640 Signed-off-by: Patrick Rudolph Reviewed-on: https://review.coreboot.org/c/coreboot/+/76492 Reviewed-by: Arthur Heymans Tested-by: build bot (Jenkins) --- src/soc/intel/xeon_sp/cpx/hob_display.c | 2 +- src/soc/intel/xeon_sp/skx/hob_display.c | 2 +- src/soc/intel/xeon_sp/spr/hob_display.c | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) (limited to 'src') diff --git a/src/soc/intel/xeon_sp/cpx/hob_display.c b/src/soc/intel/xeon_sp/cpx/hob_display.c index 961f9080bb..87e2ef413e 100644 --- a/src/soc/intel/xeon_sp/cpx/hob_display.c +++ b/src/soc/intel/xeon_sp/cpx/hob_display.c @@ -102,7 +102,7 @@ static void soc_display_iio_universal_data_hob(const IIO_UDS *hob) printk(BIOS_DEBUG, "\tPci64BitResourceAllocation: %d\n", hob->PlatformData.Pci64BitResourceAllocation); - for (uint8_t s = 0; s < hob->PlatformData.numofIIO; ++s) { + for (uint8_t s = 0; s < MAX_SOCKET; ++s) { printk(BIOS_DEBUG, "\t============ Socket %d Info ================\n", s); printk(BIOS_DEBUG, "\tValid: 0x%x\n", hob->PlatformData.IIO_resource[s].Valid); diff --git a/src/soc/intel/xeon_sp/skx/hob_display.c b/src/soc/intel/xeon_sp/skx/hob_display.c index 9c03146ef3..bc65e64af3 100644 --- a/src/soc/intel/xeon_sp/skx/hob_display.c +++ b/src/soc/intel/xeon_sp/skx/hob_display.c @@ -151,7 +151,7 @@ void soc_display_iio_universal_data_hob(void) printk(BIOS_DEBUG, "\tMmiohGranularity: hi: 0x%x, lo:0x%x\n", hob->PlatformData.MmiohGranularity.hi, hob->PlatformData.MmiohGranularity.lo); - for (int s = 0; s < hob->PlatformData.numofIIO; ++s) { + for (int s = 0; s < MAX_SOCKET; ++s) { printk(BIOS_DEBUG, "\t============ Socket %d Info ================\n", s); printk(BIOS_DEBUG, "\tSocketID: 0x%x\n", hob->PlatformData.IIO_resource[s].SocketID); diff --git a/src/soc/intel/xeon_sp/spr/hob_display.c b/src/soc/intel/xeon_sp/spr/hob_display.c index cba2d9c8e7..582413cdfe 100644 --- a/src/soc/intel/xeon_sp/spr/hob_display.c +++ b/src/soc/intel/xeon_sp/spr/hob_display.c @@ -130,7 +130,7 @@ void soc_display_iio_universal_data_hob(const IIO_UDS *hob) printk(BIOS_DEBUG, "\tMmiohGranularity: hi: 0x%x, lo:0x%x\n", hob->PlatformData.MmiohGranularity.hi, hob->PlatformData.MmiohGranularity.lo); - for (uint8_t s = 0; s < hob->PlatformData.numofIIO; ++s) { + for (uint8_t s = 0; s < MAX_SOCKET; ++s) { printk(BIOS_DEBUG, "\t============ Socket %d Info ================\n", s); printk(BIOS_DEBUG, "\tValid: 0x%x\n", hob->PlatformData.IIO_resource[s].Valid); printk(BIOS_DEBUG, "\tSocketID: 0x%x\n", -- cgit v1.2.3