From 8d0d57f0a2ed454f0036caae6d6ac30c5eb77a52 Mon Sep 17 00:00:00 2001 From: Arthur Heymans Date: Wed, 3 Apr 2024 15:56:27 +0200 Subject: Kconfig: Reverse ARCH_SUPPORTS_CLANG Since most targets support clang it's easier to reverse the semantics of the Kconfig options. Change-Id: Ib28e7a4cb286b9f8b05be94dae3947179f43c746 Signed-off-by: Arthur Heymans Reviewed-on: https://review.coreboot.org/c/coreboot/+/81659 Tested-by: build bot (Jenkins) Reviewed-by: Nico Huber Reviewed-by: Maximilian Brune --- src/Kconfig | 10 +++++----- src/arch/arm/Kconfig | 1 + src/arch/arm64/Kconfig | 1 + src/arch/ppc64/Kconfig | 1 - src/arch/riscv/Kconfig | 1 - src/arch/x86/Kconfig | 1 - 6 files changed, 7 insertions(+), 8 deletions(-) (limited to 'src') diff --git a/src/Kconfig b/src/Kconfig index ef3c72cc2d..b6dc67f00a 100644 --- a/src/Kconfig +++ b/src/Kconfig @@ -74,7 +74,7 @@ config COMPILER_GCC config COMPILER_LLVM_CLANG bool "LLVM/clang" - depends on ALLOW_EXPERIMENTAL_CLANG || ARCH_SUPPORTS_CLANG + depends on ALLOW_EXPERIMENTAL_CLANG || !CLANG_UNSUPPORTED help Use LLVM/clang to build coreboot. To use this, you must build the coreboot version of the clang compiler. Run the command @@ -85,15 +85,15 @@ config COMPILER_LLVM_CLANG endchoice -config ARCH_SUPPORTS_CLANG +config CLANG_UNSUPPORTED bool help - Opt-in flag for architectures that generally work well with CLANG. - By default the option would be hidden. + Set this flag on platforms that do not support building with the + clang compiler. config ALLOW_EXPERIMENTAL_CLANG bool "Allow experimental LLVM/Clang" - depends on !ARCH_SUPPORTS_CLANG + depends on CLANG_UNSUPPORTED help On some architectures CLANG does not work that well. Use this only to try to get CLANG working. diff --git a/src/arch/arm/Kconfig b/src/arch/arm/Kconfig index 64fe915c4b..0829dcbbcb 100644 --- a/src/arch/arm/Kconfig +++ b/src/arch/arm/Kconfig @@ -2,6 +2,7 @@ config ARCH_ARM bool + select CLANG_UNSUPPORTED config ARCH_BOOTBLOCK_ARM bool diff --git a/src/arch/arm64/Kconfig b/src/arch/arm64/Kconfig index af5050b21b..ea7b5aae71 100644 --- a/src/arch/arm64/Kconfig +++ b/src/arch/arm64/Kconfig @@ -2,6 +2,7 @@ config ARCH_ARM64 bool + select CLANG_UNSUPPORTED config ARCH_BOOTBLOCK_ARM64 bool diff --git a/src/arch/ppc64/Kconfig b/src/arch/ppc64/Kconfig index 93e4929274..25a0f500ef 100644 --- a/src/arch/ppc64/Kconfig +++ b/src/arch/ppc64/Kconfig @@ -2,7 +2,6 @@ config ARCH_PPC64 bool - select ARCH_SUPPORTS_CLANG config ARCH_BOOTBLOCK_PPC64 bool diff --git a/src/arch/riscv/Kconfig b/src/arch/riscv/Kconfig index b570b0147c..66c64c2cd3 100644 --- a/src/arch/riscv/Kconfig +++ b/src/arch/riscv/Kconfig @@ -10,7 +10,6 @@ config ARCH_RISCV_RV32 config ARCH_RISCV bool - select ARCH_SUPPORTS_CLANG if ARCH_RISCV diff --git a/src/arch/x86/Kconfig b/src/arch/x86/Kconfig index c0fe6dcf1b..16d8a7041d 100644 --- a/src/arch/x86/Kconfig +++ b/src/arch/x86/Kconfig @@ -5,7 +5,6 @@ config ARCH_X86 select PCI select RELOCATABLE_MODULES select HAVE_ASAN_IN_RAMSTAGE - select ARCH_SUPPORTS_CLANG if ARCH_X86 -- cgit v1.2.3