From 74a986db9fb2d900b5a11a11249b74afc2ee69e8 Mon Sep 17 00:00:00 2001 From: Tarun Tuli Date: Mon, 29 May 2023 12:56:41 +0000 Subject: mb/google/brya/acpi: FBVDD_PWR_EN should be inverted on Agah The FBVDD_PWR_EN signal should be inverted in its control level on Agah v.s. Hades. The original change covered the Hades implementation, but needs to be updated to invert for Agah. This change can be removed once we drop support for Agah. BUG=b:280467267 TEST=built for Hades and Agah Change-Id: I7f90c03b8d9b859004e5c124bf0a1f7b59921c3d Signed-off-by: Tarun Tuli Reviewed-on: https://review.coreboot.org/c/coreboot/+/75530 Reviewed-by: Eric Lai Tested-by: build bot (Jenkins) Reviewed-by: Subrata Banik --- src/mainboard/google/brya/acpi/power.asl | 15 ++++++++++++--- 1 file changed, 12 insertions(+), 3 deletions(-) (limited to 'src') diff --git a/src/mainboard/google/brya/acpi/power.asl b/src/mainboard/google/brya/acpi/power.asl index 0371eda2ab..c4a84954f2 100644 --- a/src/mainboard/google/brya/acpi/power.asl +++ b/src/mainboard/google/brya/acpi/power.asl @@ -128,8 +128,12 @@ Method (GC6I, 0, Serialized) /* Deassert PG_GPU_ALLRAILS */ CTXS (GPIO_GPU_ALLRAILS_PG) - /* Deassert FBVDDQ Enable */ + /* Ramp down FBVDD - TODO: Remove Agah when board is dropped */ +#if CONFIG(BOARD_GOOGLE_AGAH) + STXS (GPIO_FBVDD_PWR_EN) +#else CTXS (GPIO_FBVDD_PWR_EN) +#endif /* Ramp down PEXVDD */ CTXS (GPIO_PEXVDD_PWR_EN) @@ -176,8 +180,13 @@ Method (GC6O, 0, Serialized) STXS (GPIO_PEXVDD_PWR_EN) GPPL (GPIO_PEXVDD_PG, 1, 4) - /* Assert FBVDDQ Enable */ - STXS (GPIO_FBVDD_PWR_EN) + /* Ramp up FBVDD - TODO: Remove Agah when board is dropped */ +#if CONFIG(BOARD_GOOGLE_AGAH) + CTXS (GPIO_FBVDD_PWR_EN) +#else + STXS (GPIO_FBVDD_PWR_EN) +#endif + /* Assert PG_GPU_ALLRAILS */ STXS (GPIO_GPU_ALLRAILS_PG) -- cgit v1.2.3