From 6ffaf5a6912233b7464609ad2b3df240574cf893 Mon Sep 17 00:00:00 2001 From: Seunghwan Kim Date: Mon, 8 Mar 2021 17:41:28 +0900 Subject: mb/google/dedede/var/sasuke: Configure I2C times for touchpad/audio Configure I2C rise/fall time in device tree to ensure I2C CLK runs accurately at I2C_SPEED_FAST (< 400 kHz). Measured I2C frequency just as below after tuning: I2C0(touchpad): 385 kHz I2C4(audio): 380 kHz BUG=b:180335053 BRANCH=dedede TEST=Build and check after tuning I2C clock is under 400kHz Change-Id: Ic92ee0379456e80260a8026bc38ee41325dad6d2 Signed-off-by: Seunghwan Kim Reviewed-on: https://review.coreboot.org/c/coreboot/+/51335 Tested-by: build bot (Jenkins) Reviewed-by: Karthik Ramasubramanian --- src/mainboard/google/dedede/variants/sasuke/overridetree.cb | 13 ++++--------- 1 file changed, 4 insertions(+), 9 deletions(-) (limited to 'src') diff --git a/src/mainboard/google/dedede/variants/sasuke/overridetree.cb b/src/mainboard/google/dedede/variants/sasuke/overridetree.cb index 2fb1d6120f..bcc4b49e1f 100644 --- a/src/mainboard/google/dedede/variants/sasuke/overridetree.cb +++ b/src/mainboard/google/dedede/variants/sasuke/overridetree.cb @@ -61,9 +61,8 @@ chip soc/intel/jasperlake }, .i2c[0] = { .speed = I2C_SPEED_FAST, - .rise_time_ns = 66, - .fall_time_ns = 90, - .data_hold_time_ns = 350, + .rise_time_ns = 209, + .fall_time_ns = 12, }, .i2c[1] = { .speed = I2C_SPEED_FAST, @@ -76,12 +75,8 @@ chip soc/intel/jasperlake }, .i2c[4] = { .speed = I2C_SPEED_FAST, - .speed_config[0] = { - .speed = I2C_SPEED_FAST, - .scl_lcnt = 176, - .scl_hcnt = 95, - .sda_hold = 36, - } + .rise_time_ns = 175, + .fall_time_ns = 8, }, }" device domain 0 on -- cgit v1.2.3