From 6eced03b25954e370e20e62f2cbe41f9d5626eae Mon Sep 17 00:00:00 2001 From: Raul E Rangel Date: Wed, 5 May 2021 13:32:36 -0600 Subject: soc/amd/common/espi: Don't set alert pin in espi_set_initial_config The eSPI spec says that the Alert Mode defaults to in-band on reset. This change ensures the controller is in sync with the eSPI peripheral. The configured alert mode is configured in espi_set_general_configuration. BUG=b:187122344, b:186135022 TEST=Boot guybrush and make sure we don't get any eSPI errors. Signed-off-by: Raul E Rangel Change-Id: Ib43e190d08d77ecfcd22ead2bf42e5de2202b555 Reviewed-on: https://review.coreboot.org/c/coreboot/+/52953 Reviewed-by: Karthik Ramasubramanian Reviewed-by: Furquan Shaikh Reviewed-by: Rob Barnes Tested-by: build bot (Jenkins) --- src/soc/amd/common/block/lpc/espi_util.c | 3 --- 1 file changed, 3 deletions(-) (limited to 'src') diff --git a/src/soc/amd/common/block/lpc/espi_util.c b/src/soc/amd/common/block/lpc/espi_util.c index ade1aaa60f..519130a653 100644 --- a/src/soc/amd/common/block/lpc/espi_util.c +++ b/src/soc/amd/common/block/lpc/espi_util.c @@ -864,9 +864,6 @@ static void espi_set_initial_config(const struct espi_config *mb_cfg) { uint32_t espi_initial_mode = ESPI_OP_FREQ_16_MHZ | ESPI_IO_MODE_SINGLE; - if (mb_cfg->dedicated_alert_pin) - espi_initial_mode |= ESPI_ALERT_MODE; - espi_write32(ESPI_SLAVE0_CONFIG, espi_initial_mode); } -- cgit v1.2.3