From 68a51ec0d31055222d84909249a40fd275c38060 Mon Sep 17 00:00:00 2001 From: Sean Rhodes Date: Wed, 2 Oct 2024 15:25:30 +0100 Subject: mb/starlabs/*: Don't disable Turbo Boost in Power Saver profile Tested on 24.04, disabling Turbo Boost increases power consumption which doesn't align with the aim of the Power Saver profile. Change-Id: I19e8189ee6c44d19bf222c921429284ed1e1aa2a Signed-off-by: Sean Rhodes Reviewed-on: https://review.coreboot.org/c/coreboot/+/84628 Reviewed-by: Matt DeVillier Tested-by: build bot (Jenkins) --- src/mainboard/starlabs/byte_adl/variants/mk_ii/devtree.c | 1 - src/mainboard/starlabs/lite/devtree.c | 1 - src/mainboard/starlabs/starbook/variants/adl/devtree.c | 1 - src/mainboard/starlabs/starbook/variants/cml/devtree.c | 1 - src/mainboard/starlabs/starbook/variants/kbl/devtree.c | 1 - src/mainboard/starlabs/starbook/variants/rpl/devtree.c | 1 - src/mainboard/starlabs/starbook/variants/tgl/devtree.c | 1 - src/mainboard/starlabs/starlite_adl/variants/mk_v/devtree.c | 1 - 8 files changed, 8 deletions(-) (limited to 'src') diff --git a/src/mainboard/starlabs/byte_adl/variants/mk_ii/devtree.c b/src/mainboard/starlabs/byte_adl/variants/mk_ii/devtree.c index 96e0b9326a..be9825e3b2 100644 --- a/src/mainboard/starlabs/byte_adl/variants/mk_ii/devtree.c +++ b/src/mainboard/starlabs/byte_adl/variants/mk_ii/devtree.c @@ -23,7 +23,6 @@ void devtree_update(void) /* Update PL1 & PL2 based on CMOS settings */ switch (get_power_profile(PP_POWER_SAVER)) { case PP_POWER_SAVER: - disable_turbo(); soc_conf_4core->tdp_pl1_override = 6; soc_conf_4core->tdp_pl2_override = 10; common_config->pch_thermal_trip = 30; diff --git a/src/mainboard/starlabs/lite/devtree.c b/src/mainboard/starlabs/lite/devtree.c index d3f8100b5d..1f6a92211c 100644 --- a/src/mainboard/starlabs/lite/devtree.c +++ b/src/mainboard/starlabs/lite/devtree.c @@ -27,7 +27,6 @@ void devtree_update(void) /* Update PL1 & PL2 based on CMOS settings */ switch (get_power_profile(PP_POWER_SAVER)) { case PP_POWER_SAVER: - disable_turbo(); soc_conf->tdp_pl1_override = 6; soc_conf->tdp_pl2_override = 10; cfg->tcc_offset = 15; diff --git a/src/mainboard/starlabs/starbook/variants/adl/devtree.c b/src/mainboard/starlabs/starbook/variants/adl/devtree.c index 27ab6c90f2..fb961e20bd 100644 --- a/src/mainboard/starlabs/starbook/variants/adl/devtree.c +++ b/src/mainboard/starlabs/starbook/variants/adl/devtree.c @@ -24,7 +24,6 @@ void devtree_update(void) /* Update PL1 & PL2 based on CMOS settings */ switch (get_power_profile(PP_POWER_SAVER)) { case PP_POWER_SAVER: - disable_turbo(); soc_conf_10core->tdp_pl1_override = 15; soc_conf_12core->tdp_pl1_override = 15; soc_conf_10core->tdp_pl2_override = 15; diff --git a/src/mainboard/starlabs/starbook/variants/cml/devtree.c b/src/mainboard/starlabs/starbook/variants/cml/devtree.c index 95a5d44ea3..100a85c274 100644 --- a/src/mainboard/starlabs/starbook/variants/cml/devtree.c +++ b/src/mainboard/starlabs/starbook/variants/cml/devtree.c @@ -19,7 +19,6 @@ void devtree_update(void) /* Update PL1 & PL2 based on CMOS settings */ switch (get_power_profile(PP_POWER_SAVER)) { case PP_POWER_SAVER: - disable_turbo(); soc_conf->tdp_pl1_override = 15; soc_conf->tdp_pl2_override = 15; cfg->tcc_offset = 20; diff --git a/src/mainboard/starlabs/starbook/variants/kbl/devtree.c b/src/mainboard/starlabs/starbook/variants/kbl/devtree.c index 38017dc2e9..5ee3a3ef8d 100644 --- a/src/mainboard/starlabs/starbook/variants/kbl/devtree.c +++ b/src/mainboard/starlabs/starbook/variants/kbl/devtree.c @@ -19,7 +19,6 @@ void devtree_update(void) /* Update PL1 & PL2 based on CMOS settings */ switch (get_power_profile(PP_POWER_SAVER)) { case PP_POWER_SAVER: - disable_turbo(); soc_conf->tdp_pl1_override = 15; soc_conf->tdp_pl2_override = 15; cfg->tcc_offset = 20; diff --git a/src/mainboard/starlabs/starbook/variants/rpl/devtree.c b/src/mainboard/starlabs/starbook/variants/rpl/devtree.c index b190865975..a7b0157bb8 100644 --- a/src/mainboard/starlabs/starbook/variants/rpl/devtree.c +++ b/src/mainboard/starlabs/starbook/variants/rpl/devtree.c @@ -27,7 +27,6 @@ void devtree_update(void) /* Update PL1 & PL2 based on CMOS settings */ switch (get_power_profile(PP_POWER_SAVER)) { case PP_POWER_SAVER: - disable_turbo(); soc_conf_6core->tdp_pl1_override = 15; soc_conf_12core->tdp_pl1_override = 15; soc_conf_6core->tdp_pl2_override = 15; diff --git a/src/mainboard/starlabs/starbook/variants/tgl/devtree.c b/src/mainboard/starlabs/starbook/variants/tgl/devtree.c index 7c94430ee8..8d206fa38c 100644 --- a/src/mainboard/starlabs/starbook/variants/tgl/devtree.c +++ b/src/mainboard/starlabs/starbook/variants/tgl/devtree.c @@ -26,7 +26,6 @@ void devtree_update(void) /* Update PL1 & PL2 based on CMOS settings */ switch (get_power_profile(PP_POWER_SAVER)) { case PP_POWER_SAVER: - disable_turbo(); soc_conf_2core->tdp_pl1_override = 15; soc_conf_4core->tdp_pl1_override = 15; soc_conf_2core->tdp_pl2_override = 15; diff --git a/src/mainboard/starlabs/starlite_adl/variants/mk_v/devtree.c b/src/mainboard/starlabs/starlite_adl/variants/mk_v/devtree.c index b07fc4cb0b..2599a49f15 100644 --- a/src/mainboard/starlabs/starlite_adl/variants/mk_v/devtree.c +++ b/src/mainboard/starlabs/starlite_adl/variants/mk_v/devtree.c @@ -25,7 +25,6 @@ void devtree_update(void) /* Update PL1 & PL2 based on CMOS settings */ switch (get_power_profile(PP_POWER_SAVER)) { case PP_POWER_SAVER: - disable_turbo(); soc_conf_4core->tdp_pl1_override = 6; soc_conf_4core->tdp_pl2_override = 10; common_config->pch_thermal_trip = 30; -- cgit v1.2.3