From 681012ab3d500bcbda3971d122e60587133df1cd Mon Sep 17 00:00:00 2001 From: Alexandru Gagniuc Date: Sat, 29 Aug 2015 17:48:01 -0700 Subject: drivers/intel/fsp_1_1: Remove useless #ifndef/#error pairs The #error messages only say that "CONFIG_* must be defined", which conveys no more information that the compiler or assembler failing when it encounters an undefined CONFIG_* symbol. Change-Id: I6058474d4cd454cfc20290650425d379f388abd9 Signed-off-by: Alexandru Gagniuc Reviewed-on: http://review.coreboot.org/11461 Tested-by: build bot (Jenkins) Reviewed-by: Stefan Reinauer --- src/drivers/intel/fsp1_1/cache_as_ram.inc | 18 ------------------ src/drivers/intel/fsp1_1/fsp_util.c | 4 ---- 2 files changed, 22 deletions(-) (limited to 'src') diff --git a/src/drivers/intel/fsp1_1/cache_as_ram.inc b/src/drivers/intel/fsp1_1/cache_as_ram.inc index f56d841380..6af30ce5e5 100644 --- a/src/drivers/intel/fsp1_1/cache_as_ram.inc +++ b/src/drivers/intel/fsp1_1/cache_as_ram.inc @@ -33,24 +33,6 @@ #include #include -#ifndef CONFIG_FSP_LOC -# error "CONFIG_FSP_LOC must be set." -#endif - -#ifndef CONFIG_POST_IO -# error "CONFIG_POST_IO must be set." -#endif - -#if IS_ENABLED(CONFIG_POST_IO) -# ifndef CONFIG_POST_IO_PORT -# error "CONFIG_POST_IO_PORT must be set." -# endif -#endif - -#ifndef CONFIG_CPU_MICROCODE_CBFS_LOC -# error "CONFIG_CPU_MICROCODE_CBFS_LOC must be set." -#endif - #define LHLT_DELAY 0x50000 /* I/O delay between post codes on failure */ /* diff --git a/src/drivers/intel/fsp1_1/fsp_util.c b/src/drivers/intel/fsp1_1/fsp_util.c index 51ddc67de3..e5624b3c43 100644 --- a/src/drivers/intel/fsp1_1/fsp_util.c +++ b/src/drivers/intel/fsp1_1/fsp_util.c @@ -38,10 +38,6 @@ FSP_INFO_HEADER *find_fsp(void) } fsp_ptr; u32 *image_id; -#ifndef CONFIG_FSP_LOC -#error "CONFIG_FSP_LOC must be set." -#endif - for (;;) { /* Get the FSP binary base address in CBFS */ fsp_ptr.u8 = (u8 *)CONFIG_FSP_LOC; -- cgit v1.2.3