From 674ee501e84c43e8a69d35f8432e920c7baecf66 Mon Sep 17 00:00:00 2001
From: CoolStar <coolstarorganization@gmail.com>
Date: Thu, 25 Apr 2024 17:06:13 -0700
Subject: drivers/intel/mipi_camera: Add CSI2 Data Stream Interface GUID
Required in SSDB for Windows drivers. Tested on google/brya (kano)
and verified Intel Webcam shows up to Windows as a camera source
Change-Id: Id6089f6bd841333882e28de9307fe5e48e368d02
Signed-off-by: CoolStar <coolstarorganization@gmail.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/82068
Reviewed-by: Matt DeVillier <matt.devillier@gmail.com>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
---
src/drivers/intel/mipi_camera/camera.c | 6 ++++++
src/drivers/intel/mipi_camera/chip.h | 3 ++-
2 files changed, 8 insertions(+), 1 deletion(-)
(limited to 'src')
diff --git a/src/drivers/intel/mipi_camera/camera.c b/src/drivers/intel/mipi_camera/camera.c
index 92c45a8aea..190adc7349 100644
--- a/src/drivers/intel/mipi_camera/camera.c
+++ b/src/drivers/intel/mipi_camera/camera.c
@@ -11,6 +11,10 @@
#include <device/pci_def.h>
#include "chip.h"
+#define CSI2_DATA_STREAM_INTERFACE_GUID \
+ GUID_INIT(0x8A395669, 0x11F7, 0x4EA9, \
+ 0x9C, 0x7D, 0x20, 0xEE, 0x0A, 0xB5, 0xCA, 0x40)
+
#define SENSOR_NAME_UUID "822ace8f-2814-4174-a56b-5f029fe079ee"
#define SENSOR_TYPE_UUID "26257549-9271-4ca4-bb43-c4899d5a4881"
#define DEFAULT_ENDPOINT 0
@@ -285,6 +289,8 @@ static void camera_fill_ssdb_defaults(struct drivers_intel_mipi_camera_config *c
if (config->disable_ssdb_defaults)
return;
+ guidcpy(&config->ssdb.csi2_data_stream_interface, &CSI2_DATA_STREAM_INTERFACE_GUID);
+
if (!config->ssdb.bdf_value)
config->ssdb.bdf_value = PCI_DEVFN(CIO2_PCI_DEV, CIO2_PCI_FN);
diff --git a/src/drivers/intel/mipi_camera/chip.h b/src/drivers/intel/mipi_camera/chip.h
index ecf371458b..9aba729b32 100644
--- a/src/drivers/intel/mipi_camera/chip.h
+++ b/src/drivers/intel/mipi_camera/chip.h
@@ -5,6 +5,7 @@
#include <stdint.h>
#include <acpi/acpi_pld.h>
+#include <uuid.h>
#define DEFAULT_LINK_FREQ 450000000
#define MAX_PWDB_ENTRIES 12
@@ -143,7 +144,7 @@ struct operation_seq {
struct intel_ssdb {
uint8_t version; /* Current version */
uint8_t sensor_card_sku; /* CRD Board type */
- uint8_t csi2_data_stream_interface[16]; /* CSI2 data stream GUID */
+ guid_t csi2_data_stream_interface; /* CSI2 data stream GUID */
uint16_t bdf_value; /* Bus number of the host
controller */
uint32_t dphy_link_en_fuses; /* Host controller's fuses
--
cgit v1.2.3