From 6466354ee97e630af5b66e6bfc1efc4b9fe42243 Mon Sep 17 00:00:00 2001 From: Maximilian Brune Date: Mon, 3 Jun 2024 05:24:32 +0200 Subject: lib/device_tree.c: Fix wrong check for FDT validity Obviously one should return NULL if a FDT is not valid an not the other way around. Signed-off-by: Maximilian Brune Change-Id: I77c0e187b841e60965daac17025110181bdd32bc Reviewed-on: https://review.coreboot.org/c/coreboot/+/82773 Tested-by: build bot (Jenkins) Reviewed-by: Elyes Haouas --- src/lib/device_tree.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'src') diff --git a/src/lib/device_tree.c b/src/lib/device_tree.c index aff9e157cd..4f5cc07e91 100644 --- a/src/lib/device_tree.c +++ b/src/lib/device_tree.c @@ -608,7 +608,7 @@ struct device_tree *fdt_unflatten(const void *blob) const struct fdt_header *header = (const struct fdt_header *)blob; tree->header = header; - if (fdt_is_valid(blob)) + if (!fdt_is_valid(blob)) return NULL; uint32_t struct_offset = be32toh(header->structure_offset); -- cgit v1.2.3