From 61fcd14561b226c4cca32148629c4ed42db9f645 Mon Sep 17 00:00:00 2001 From: Stefan Reinauer Date: Wed, 14 Aug 2013 17:14:39 -0700 Subject: Exynos5: Remove unneeded USB delays Change-Id: I1144e9d6d6c4278842fdd36743c8a88555f81707 Signed-off-by: Stefan Reinauer Reviewed-on: https://gerrit.chromium.org/gerrit/65912 Reviewed-by: Ronald G. Minnich Commit-Queue: Stefan Reinauer Tested-by: Stefan Reinauer (cherry picked from commit 95b518877edc88347ce9725ffee32f3aed0de7dc) Signed-off-by: Isaac Christensen Reviewed-on: http://review.coreboot.org/6505 Tested-by: build bot (Jenkins) Reviewed-by: Ronald G. Minnich Reviewed-by: Edward O'Callaghan Reviewed-by: Paul Menzel --- src/cpu/samsung/exynos5250/usb.c | 9 +++++---- src/cpu/samsung/exynos5420/usb.c | 9 +++++---- 2 files changed, 10 insertions(+), 8 deletions(-) (limited to 'src') diff --git a/src/cpu/samsung/exynos5250/usb.c b/src/cpu/samsung/exynos5250/usb.c index d8e07da080..5084707e36 100644 --- a/src/cpu/samsung/exynos5250/usb.c +++ b/src/cpu/samsung/exynos5250/usb.c @@ -88,10 +88,11 @@ static void setup_usb_phy(struct usb_phy *usb, int hsic_gpio) udelay(10); clrbits_le32(&usb->hsicphyctrl1, HOST_CTRL0_PHYSWRST); - /* PHY clock and power setup time */ - // FIXME If this happens more than 50ms before executing the payload, - // we might not need this delay. - mdelay(50); + /* At this point we need to wait for 50ms before talking to + * the USB controller (PHY clock and power setup time) + * By the time we are actually in the payload, these 50ms + * will have passed. + */ } void usb_init(device_t dev) diff --git a/src/cpu/samsung/exynos5420/usb.c b/src/cpu/samsung/exynos5420/usb.c index 4d0769970a..6e79ef1d0e 100644 --- a/src/cpu/samsung/exynos5420/usb.c +++ b/src/cpu/samsung/exynos5420/usb.c @@ -88,10 +88,11 @@ static void setup_usb_phy(struct usb_phy *usb, int hsic_gpio) udelay(10); clrbits_le32(&usb->hsicphyctrl1, HOST_CTRL0_PHYSWRST); - /* PHY clock and power setup time */ - // FIXME If this happens more than 50ms before executing the payload, - // we might not need this delay. - mdelay(50); + /* At this point we need to wait for 50ms before talking to + * the USB controller (PHY clock and power setup time) + * By the time we are actually in the payload, these 50ms + * will have passed. + */ } void usb_init(device_t dev) -- cgit v1.2.3