From 610b016caf3170fc2bd92603bd75c1e69d4cbeb6 Mon Sep 17 00:00:00 2001 From: Felix Singer Date: Sun, 5 Dec 2021 07:33:39 +0100 Subject: mainboard: Drop `SataMode` setting from Cannon Lake devicetrees All Coffee Lake mainboards use the default value for the setting `SataMode`. Thus, drop it from their devicetree. Change-Id: Ibb329eb8b752c2220bb25f14fb6ae92dd8a308d6 Signed-off-by: Felix Singer Reviewed-on: https://review.coreboot.org/c/coreboot/+/59889 Reviewed-by: Angel Pons Tested-by: build bot (Jenkins) --- src/mainboard/google/hatch/variants/akemi/variant.c | 1 - src/mainboard/google/hatch/variants/kindred/variant.c | 1 - src/mainboard/prodrive/hermes/devicetree.cb | 1 - src/mainboard/purism/librem_cnl/variants/librem_14/devicetree.cb | 1 - 4 files changed, 4 deletions(-) (limited to 'src') diff --git a/src/mainboard/google/hatch/variants/akemi/variant.c b/src/mainboard/google/hatch/variants/akemi/variant.c index 00649c221e..cc38362f62 100644 --- a/src/mainboard/google/hatch/variants/akemi/variant.c +++ b/src/mainboard/google/hatch/variants/akemi/variant.c @@ -29,7 +29,6 @@ void variant_devtree_update(void) return; ssd_host->enabled = 0; cfg->SataSalpSupport = 0; - cfg->SataMode = 0; cfg->SataPortsEnable[1] = 0; cfg->SataPortsDevSlp[1] = 0; cfg->satapwroptimize = 0; diff --git a/src/mainboard/google/hatch/variants/kindred/variant.c b/src/mainboard/google/hatch/variants/kindred/variant.c index 3510dbb68e..7e63526562 100644 --- a/src/mainboard/google/hatch/variants/kindred/variant.c +++ b/src/mainboard/google/hatch/variants/kindred/variant.c @@ -30,7 +30,6 @@ void variant_devtree_update(void) return; ssd_host->enabled = 0; cfg->SataSalpSupport = 0; - cfg->SataMode = 0; cfg->SataPortsEnable[1] = 0; cfg->SataPortsDevSlp[1] = 0; cfg->satapwroptimize = 0; diff --git a/src/mainboard/prodrive/hermes/devicetree.cb b/src/mainboard/prodrive/hermes/devicetree.cb index e0655c5630..db573821cf 100644 --- a/src/mainboard/prodrive/hermes/devicetree.cb +++ b/src/mainboard/prodrive/hermes/devicetree.cb @@ -1,7 +1,6 @@ chip soc/intel/cannonlake # FSP configuration - register "SataMode" = "0" # AHCI register "SataSalpSupport" = "0" register "satapwroptimize" = "1" register "SataPortsDevSlp[1]" = "1" # PCH_M2_SATA_DEVSLP1 diff --git a/src/mainboard/purism/librem_cnl/variants/librem_14/devicetree.cb b/src/mainboard/purism/librem_cnl/variants/librem_14/devicetree.cb index c8d6816958..8b5c9086b9 100644 --- a/src/mainboard/purism/librem_cnl/variants/librem_14/devicetree.cb +++ b/src/mainboard/purism/librem_cnl/variants/librem_14/devicetree.cb @@ -199,7 +199,6 @@ chip soc/intel/cannonlake device pci 16.4 off end # Management Engine Interface 3 device pci 16.5 off end # Management Engine Interface 4 device pci 17.0 on # SATA - register "SataMode" = "SATA_AHCI" register "satapwroptimize" = "1" register "SataSalpSupport" = "1" # Port 2 (M.2 / inner) -- cgit v1.2.3