From 58d39d07a14f4f1e253fc43c36d66c216ce682d1 Mon Sep 17 00:00:00 2001 From: Furquan Shaikh Date: Sat, 3 Oct 2020 14:57:20 -0700 Subject: drivers/intel/wifi: Drop call to pci_dev_init MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit `pci_dev_init()` is used to load and run option ROM on VGA class devices (PCI_CLASS_DISPLAY_VGA). WiFi device is not a VGA class device and hence the call to `pci_dev_init()` is not required. This change drops the call to `pci_dev_init()` from `wifi_pci_dev_init()` in Intel WiFi driver. BUG=b:169802515 BRANCH=zork Change-Id: I6588ea0a5c848904088d05fd1cbdf677b2dc8ea9 Signed-off-by: Furquan Shaikh Reviewed-on: https://review.coreboot.org/c/coreboot/+/46029 Tested-by: build bot (Jenkins) Reviewed-by: Rob Barnes Reviewed-by: Duncan Laurie Reviewed-by: Michael Niewöhner Reviewed-by: Karthik Ramasubramanian --- src/drivers/intel/wifi/wifi.c | 2 -- 1 file changed, 2 deletions(-) (limited to 'src') diff --git a/src/drivers/intel/wifi/wifi.c b/src/drivers/intel/wifi/wifi.c index 0ad0e1c4a1..e117ec0af7 100644 --- a/src/drivers/intel/wifi/wifi.c +++ b/src/drivers/intel/wifi/wifi.c @@ -63,8 +63,6 @@ static void intel_wifi_fill_ssdt(const struct device *dev) static void wifi_pci_dev_init(struct device *dev) { - pci_dev_init(dev); - if (CONFIG(ELOG)) { uint32_t val; val = pci_read_config16(dev, PMCS_DR); -- cgit v1.2.3