From 5578d912576a518175c8067b0ad88961b9032660 Mon Sep 17 00:00:00 2001 From: Subrata Banik Date: Thu, 16 Nov 2023 19:24:52 +0000 Subject: mb/{google,intel}/{rex,mtlrvp}: Enable SOC_INTEL_COMMON_BASECODE_RAMTOP This patch enables the `SOC_INTEL_COMMON_BASECODE_RAMTOP` config option for select mainboards, as not all board variants may want to enable this config due to underlying SoC dependencies. Mainboards that attempt to enable early caching have exhibited soft hangs while switching between pre-RAM and post-RAM phases. This patch allows mainboards to choose to enable this option without enabling it by default (which could cause boot hangs). Furthermore, it reorganizes the configuration options under BOARD_GOOGLE_BASEBOARD_REX in alphabetical order for better readability. BUG=b:306677879 TEST=Enable SOC_INTEL_COMMON_BASECODE_RAMTOP for google/rex and intel/mtlrvp. Change-Id: If380c2ecbee4f6437c3d58bfb55be076a4902997 Signed-off-by: Subrata Banik Reviewed-on: https://review.coreboot.org/c/coreboot/+/79048 Tested-by: build bot (Jenkins) Reviewed-by: Kapil Porwal --- src/mainboard/google/rex/Kconfig | 5 +++-- src/mainboard/intel/mtlrvp/Kconfig | 1 + 2 files changed, 4 insertions(+), 2 deletions(-) (limited to 'src') diff --git a/src/mainboard/google/rex/Kconfig b/src/mainboard/google/rex/Kconfig index c162a44473..d7f8e4c2c5 100644 --- a/src/mainboard/google/rex/Kconfig +++ b/src/mainboard/google/rex/Kconfig @@ -33,6 +33,7 @@ config BOARD_GOOGLE_REX_COMMON config BOARD_GOOGLE_BASEBOARD_REX def_bool n select BOARD_GOOGLE_REX_COMMON + select CHROMEOS_WIFI_SAR if CHROMEOS select DRIVERS_INTEL_PMC select DRIVERS_GENERIC_GPIO_KEYS select DRIVERS_WWAN_FM350GL @@ -40,12 +41,12 @@ config BOARD_GOOGLE_BASEBOARD_REX select HAVE_SLP_S0_GATE select MAINBOARD_HAS_CHROMEOS select MEMORY_SOLDERDOWN + select SOC_INTEL_COMMON_BASECODE_RAMTOP + select SOC_INTEL_ENABLE_USB4_PCIE_RESOURCES select SOC_INTEL_IOE_DIE_SUPPORT select SOC_INTEL_METEORLAKE_U_H - select SOC_INTEL_ENABLE_USB4_PCIE_RESOURCES select SYSTEM_TYPE_LAPTOP select TPM_GOOGLE_TI50 - select CHROMEOS_WIFI_SAR if CHROMEOS config BOARD_GOOGLE_MODEL_REX def_bool n diff --git a/src/mainboard/intel/mtlrvp/Kconfig b/src/mainboard/intel/mtlrvp/Kconfig index 26faf91d3f..b541b76146 100644 --- a/src/mainboard/intel/mtlrvp/Kconfig +++ b/src/mainboard/intel/mtlrvp/Kconfig @@ -17,6 +17,7 @@ config BOARD_INTEL_MTLRVP_COMMON select HAVE_ACPI_TABLES select HAVE_SPD_IN_CBFS select MAINBOARD_HAS_CHROMEOS + select SOC_INTEL_COMMON_BASECODE_RAMTOP select SOC_INTEL_COMMON_BLOCK_VARIANT_POWER_LIMIT select SOC_INTEL_CSE_LITE_SKU select SOC_INTEL_METEORLAKE_U_H -- cgit v1.2.3