From 5153cbfeb3498b75efdde6c7aa312d5920541702 Mon Sep 17 00:00:00 2001 From: Timothy Pearson Date: Mon, 9 Jan 2017 14:10:25 -0600 Subject: amd/mct/ddr3: Allow critical delay delta to go negative The critical delay delta was incorrectly specified as an unsigned short. Use a signed short instead. Found-by: Coverity Scan #1347355 Change-Id: I37d769afb8c8af85a0375ae459e9d4ab0adcca74 Signed-off-by: Timothy Pearson Reviewed-on: https://review.coreboot.org/18071 Tested-by: build bot (Jenkins) Reviewed-by: Martin Roth Reviewed-by: Paul Menzel Tested-by: Raptor Engineering Automated Test Stand --- src/northbridge/amd/amdmct/mct_ddr3/mct_d.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'src') diff --git a/src/northbridge/amd/amdmct/mct_ddr3/mct_d.c b/src/northbridge/amd/amdmct/mct_ddr3/mct_d.c index 0892857e68..7b9fa6555a 100644 --- a/src/northbridge/amd/amdmct/mct_ddr3/mct_d.c +++ b/src/northbridge/amd/amdmct/mct_ddr3/mct_d.c @@ -3028,7 +3028,7 @@ void fam15EnableTrainingMode(struct MCTStatStruc *pMCTstat, uint8_t lane; uint8_t dimm; uint16_t max_cdd_we_delta; - uint16_t cdd_trwtto_we_delta; + int16_t cdd_trwtto_we_delta; uint8_t receiver; uint8_t lane_count; uint8_t x4_present = 0; -- cgit v1.2.3